feat(cli): relative-time flags on generated commands' unix-seconds timestamps#47
Merged
Merged
Conversation
…mestamps
Generated commands forced raw unix integers on time flags while curated
commands (incident list --since/--until) accepted "7d"/"now"/dates. This
closes that gap: every unix-SECONDS timestamp flag on a generated command
now accepts a relative duration ("7d", "24h"), "+7d" for the future,
"now", a date, or raw unix seconds (back-compatible), parsed at runtime
via timeutil.Parse — the same logic curated commands use.
The generator (cligen) detects unix-seconds timestamp fields and emits a
string flag plus a genParseTimeFlag pre-parse instead of an int flag.
Detection is precise to avoid corrupting non-timestamp ints:
- millisecond timestamps (RUM/sourcemap/webhook) stay int64 — parsing
yields seconds, which would be 1000x wrong;
- durations (delay_seconds, seconds_to_ack) stay int64 — a count of
seconds, not a point in time;
- fields the spec under-documents are caught by name convention: bare
start/end window boundaries (schedule list) and the <point>_at_*_seconds
timestamp convention (close_at_seconds, created_at_*_seconds), which the
`_at_` marker distinguishes from a delay_seconds-style duration.
Help is consistent: both the cobra flag usage and the Long "Request
fields" block render these as string + the accepted-forms hint.
Verified on the local testback: incident post-mortem-list and insight
account accept relative + raw-unix values; invalid values error cleanly
client-side; full e2e suite shows zero new failures vs base.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
The cligen example help wrapped the spec's example JSON in single quotes
(--data '<json>') without escaping embedded single quotes, so an example
whose JSON contained a "'" produced a command that breaks out of the
shell quoting when copy-pasted. This was live: the monit query-diagnose
example carries a VictoriaLogs query `_stream:{status='500'}`, whose
quotes split the argument in a real shell.
Escape embedded single quotes as the standard '\'' sequence via a
shellSingleQuote helper. The escaped example round-trips through bash back
to valid JSON. Also clears the pre-existing go/unsafe-quoting CodeQL alert,
which this PR's exampleHelp refactor had re-attributed to the diff.
ysyneu
added a commit
that referenced
this pull request
Jun 15, 2026
…re-rename shadows, #50 positional args
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Generated CLI commands forced raw unix integers on their time flags, while curated commands (
incident list --since/--until) accepted ergonomic relative time (7d,now, dates). This closes that inconsistency — part of the generated-as-single-source convergence (Phase 2, after #46's generic table renderer).Every unix-SECONDS timestamp flag on a generated command now accepts:
7d,24h(= now minus that)+7dfor the futurenow…parsed at runtime via
timeutil.Parse, the exact logic curated commands already use.How
The generator (
internal/cmd/cligen) detects unix-seconds timestamp fields and emits a string flag + agenParseTimeFlagpre-parse instead of an int flag. Detection is deliberately precise so it never corrupts a non-timestamp int:start_time,end_time,start,end,*_at_*_secondsstart_timeint64Parseyields seconds → 1000× wrongdelay_seconds,seconds_to_ackint64Beyond the description-keyword signal (
unix/epoch+second), two name conventions catch fields the spec under-documents — eliminating asymmetric start/end pairs:start/endwindow boundaries (schedule list --startwas prose-only)<point>_at_*_secondsconvention (close_at_seconds,created_at_start_seconds,created_at_end_seconds) — the_at_point-in-time marker is what distinguishes these from adelay_seconds-style duration.Help stays consistent: both the cobra flag usage and the Long "Request fields" block render these as
string+ the accepted-forms hint.Verification
go build/vet/test ./...green;gofumptclean; new unit tests for the detector (incl. ms/duration exclusions + the deficient-field cases) and the runtime parse helper.incident post-mortem-list --created-at-start-seconds 30d --created-at-end-seconds nowandinsight account --start-time 7d --end-time nowreturn data; raw-unix still works; invalid values error cleanly client-side (invalid --start: ...).-tags=e2e) vs base: zero new failures (138 pass / 27 pre-existing env fails / 6 skip — same set as base).