Skip to content

Node 12 support - with suggested changes#71

Open
tomhog wants to merge 3 commits into
flatiron:mainfrom
tomhog:patch-1
Open

Node 12 support - with suggested changes#71
tomhog wants to merge 3 commits into
flatiron:mainfrom
tomhog:patch-1

Conversation

@tomhog

@tomhog tomhog commented Nov 17, 2021

Copy link
Copy Markdown

I've taken the this.response._headerNames part out of the catch statement

Xmader and others added 3 commits June 4, 2019 01:34
@k2s

k2s commented Dec 19, 2021

Copy link
Copy Markdown

Call this.response._headerNames shows the same deprecation warning.
My fix proposal is:

    if (this.response.getHeaderNames) {
      this._headers = this.response.getHeaders() || {};
    } else {
      this._headers = this.response._headers || {};
      // Patch to node core
      this.response._headerNames = this.response._headerNames || {};
    }

@lamweili

lamweili commented Jan 14, 2024

Copy link
Copy Markdown

@darrendatbui has made the changes in PR #77 which superseded this PR.
Let's continue there and close this PR.

This has been superseded by PR #64.
This PR can be closed.

Ping @indexzero @jcrugzz

@lamweili lamweili mentioned this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants