feat: add ability to use meters to size Markers#2106
Conversation
…ating that only in the needed function
|
Hi @LeonTenorio, |
…th in a box contraint to avoid so many parameters
|
Hi @JaffaKetchup |
|
Hi. Maybe need to guard a bit more, because setting BoxConstraints can be infinity but will not be null. For example I can provide |
|
@ReinisSprogis I don't think it would crash with BoxConstraints.expand(), with that value the check if the height and width are in the interval will do nothing |
Markers
|
Sorry, this slipped under the radar! We're about to release v8.3 but I won't include this now. I do think it's a good feature though, and I'm no longer working on the other thing I mentioned about markers, so it's a good candidate for the next release, which hopefully won't be as long as it's been since the last version. Instead, hopefully we can get this reviewed and merged for v8.4, which might also include #2145, #2198, and #2188. |
Add `optimizeDimensionsInMeters` option to align with circle marker layer Merge remote-tracking branch 'origin/master' into pr/2106
There was a problem hiding this comment.
LGTM! I've made some significant changes though, so I'll wait for another maintainer to review :) @fleaflet/maintainers
It now follows the caching of projections introduced in #2213, and provides a setting to optimize calculations, same as the circle layer.
…ers calculations Improve efficiency by only calculating meters dimension once when size is square Improve efficiency by using objects instead of records and minimizing constructions Minor other improvements
Improved markers demo page Fixed bugs
Feature to render marker using size in meters.
Added 4 new parameters: