Align optional metrics manifests with the default 8080 metrics endpoint - #2026
Closed
joshuabaird with Copilot wants to merge 2 commits into
Closed
Align optional metrics manifests with the default 8080 metrics endpoint#2026joshuabaird with Copilot wants to merge 2 commits into
joshuabaird with Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix code based on review comment
Align optional metrics manifests with the default 8080 metrics endpoint
Aug 3, 2026
Copilot stopped work on behalf of
joshuabaird due to an error
August 3, 2026 14:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the review feedback on
r3704368527: the metrics Service was switched tometrics:8080, but optional metrics-related manifests still referenced HTTPS/8443, creating mismatched configurations when those components are enabled. This PR makes those optional manifests consistent with the current default metrics endpoint.Service endpoint alignment
config/default/metrics_service.yamlto exposename: metricsonport/targetPort: 8080.Prometheus monitor alignment
config/prometheus/monitor.yamlto scrapeport: metricswithscheme: httpso ServiceMonitor matches the Service endpoint.NetworkPolicy alignment
config/network-policy/allow-metrics-traffic.yamlingress port from8443to8080.Metrics patch alignment
config/default/manager_metrics_patch.yamlto bind metrics on:8080so enabling the patch no longer conflicts with the Service port.Generated install bundle refresh
manifests/setup/setup.yamlto reflect the above configuration updates.