Skip to content

Align optional metrics manifests with the default 8080 metrics endpoint - #2026

Closed
joshuabaird with Copilot wants to merge 2 commits into
masterfrom
copilot/fix-code-for-review-comment
Closed

Align optional metrics manifests with the default 8080 metrics endpoint#2026
joshuabaird with Copilot wants to merge 2 commits into
masterfrom
copilot/fix-code-for-review-comment

Conversation

Copilot AI commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

This addresses the review feedback on r3704368527: the metrics Service was switched to metrics:8080, but optional metrics-related manifests still referenced HTTPS/8443, creating mismatched configurations when those components are enabled. This PR makes those optional manifests consistent with the current default metrics endpoint.

  • Service endpoint alignment

    • Updated config/default/metrics_service.yaml to expose name: metrics on port/targetPort: 8080.
  • Prometheus monitor alignment

    • Updated config/prometheus/monitor.yaml to scrape port: metrics with scheme: http so ServiceMonitor matches the Service endpoint.
  • NetworkPolicy alignment

    • Updated config/network-policy/allow-metrics-traffic.yaml ingress port from 8443 to 8080.
  • Metrics patch alignment

    • Updated config/default/manager_metrics_patch.yaml to bind metrics on :8080 so enabling the patch no longer conflicts with the Service port.
  • Generated install bundle refresh

    • Regenerated manifests/setup/setup.yaml to reflect the above configuration updates.
# Before
endpoints:
  - port: https
    scheme: https

# After
endpoints:
  - port: metrics
    scheme: http

Copilot AI changed the title [WIP] Fix code based on review comment Align optional metrics manifests with the default 8080 metrics endpoint Aug 3, 2026
Copilot AI requested a review from joshuabaird August 3, 2026 13:49
@joshuabaird joshuabaird closed this Aug 3, 2026
Copilot stopped work on behalf of joshuabaird due to an error August 3, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants