fix: make derived notifiers detach on last listener removals - #2
Open
Feichtmeier wants to merge 2 commits into
Open
fix: make derived notifiers detach on last listener removals#2Feichtmeier wants to merge 2 commits into
Feichtmeier wants to merge 2 commits into
Conversation
- Behavior change (fixes a listener leak): derived notifiers created by the
operators (`select`, `map`, `where`, `debounce`, `async`, `combineLatest*`,
`mergeWith`) now **detach from their source when their last listener is
removed**, symmetric to how they attach on the first listener. Previously a
chain stayed subscribed to its source forever (until `dispose()`), which
leaked a listener on the source every time an operator chain was created
inline and discarded (e.g. inside a `build()` / `watchValue`).
- On re-observation a chain **resyncs** its value from the current source
value, so resubscription remains correct and never stale.
- The only observable difference: while a chain has **zero** listeners it no
longer tracks its source (its `.value` is refreshed on the next
observation instead of continuously). Chains that always have at least one
listener are unaffected.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
Feichtmeier
force-pushed
the
fix/derived_notifier_detach
branch
from
July 27, 2026 11:13
b4864d7 to
9232d68
Compare
Feichtmeier
force-pushed
the
fix/derived_notifier_detach
branch
from
July 27, 2026 11:34
9232d68 to
b2a5490
Compare
Feichtmeier
marked this pull request as ready for review
July 27, 2026 12:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
select,map,where,debounce,async,combineLatest*,mergeWith) now detach from their source when their last listener is removed, symmetric to how they attach on the first listener. Previously a chain stayed subscribed to its source forever (untildispose()), which leaked a listener on the source every time an operator chain was created inline and discarded (e.g. inside abuild()/watchValue)..valueis refreshed on the next observation instead of continuously). Chains that always have at least one listener are unaffected.