Repository navigation
fix: float toggle works for a second window of the same app again - #573
Open
mattchristenson wants to merge 1 commit into
Open
mattchristenson wants to merge 1 commit into
mattchristenson wants to merge 1 commit into
Conversation
addFloatOverride() returned early if any float rule for the window's app existed, so once one window of an app floated through Super+C, Super+C on a second window of that app did nothing (forge-ext#534). a2fabeb (forge-ext#492) had fixed this by skipping other windows' rules; b504512 lost that check. Restore it, and match rules to the kind of toggle on both sides: Super+C adds and removes only this window's rule; "always float" adds and removes the app's rule (and this window's own), never the rules Super+C made for the app's other windows. Fixes forge-ext#534 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #534. See also #495 (the same report in a comment) and #492, which was fixed for this before.
Problem. Super+C (
FloatToggle) floats a window by adding a float rule for that window only (wmId) to the window overrides.addFloatOverride()returns early if any float rule for the same app already exists. So once one Text Editor window floats, Super+C on a second Text Editor window finds the first window's rule and does nothing. a2fabeb (for #492) had fixed this by skipping rules for other windows. b504512 (live resize) rewrote the function and lost that check.Change. Restore the check, and make it symmetric:
Testing. Scenario
scenarios/20_float_toggle.py:main1/6 (only the first Super+C works) → 6/6. The rest of the suite is unchanged againstmain. It was also run on a build together with the other open PRs, in the sandbox and in a real GNOME Shell 50 session.prettier@2.7.1 --checkis clean.🤖 Generated with Claude Code