Skip to content

fix: show the split direction hint again #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattchristenson wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: show the split direction hint again #574

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions lib/extension/window.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1333,7 +1333,7 @@ export class WindowManager extends GObject.Object {
focusBorderEnabled &&
tilingModeEnabled &&
!nodeWindow.isFloat() &&
!maximized &&
!maximized() &&
parentNode.childNodes.length === 1 &&
(parentNode.isCon() || parentNode.isMonitor()) &&
!(parentNode.isTabbed() || parentNode.isStacked())
Expand All @@ -1358,17 +1358,19 @@ export class WindowManager extends GObject.Object {

let rect = metaWindow.get_frame_rect();

// Just above the focused window, each border above the one before it: the split hint (last)
// shares the focus border's place and would be hidden under it otherwise
let below = metaWindow.get_compositor_private();
borders.forEach((border) => {
border.set_size(rect.width + inset * 2, rect.height + inset * 2);
border.set_position(rect.x - inset, rect.y - inset);
if (metaWindow.appears_focused && !metaWindow.minimized) {
border.show();
}
if (global.window_group && global.window_group.contains(border)) {
// TODO - sort the borders with split border being on top
global.window_group.remove_child(border);
// Add the border just above the focused window
global.window_group.insert_child_above(border, metaWindow.get_compositor_private());
global.window_group.insert_child_above(border, below);
below = border;
}
});
}
Expand Down