Skip to content

fix(offload-test): a repo with no configured command gets a neutral check, not a red one - #153

Merged
debuggingfuture merged 1 commit into
mainfrom
fix/offload-test-unconfigured-neutral
Sep 22, 2026
Merged

debuggingfuture merged 1 commit into
mainfrom
fix/offload-test-unconfigured-neutral

Conversation

@debuggingfuture

Copy link
Copy Markdown
Member

A repository that never configured an offload-test command now gets a neutral flare-dispatch/offload-test check that names the key to set, instead of a red one.

Problem & Insight

The pull_request trigger fires on every non-draft PR in every repository the App is installed on, and its gate reads only the payload, so nothing can opt a repository out. A repository that runs its tests elsewhere, for example through its own workflow dispatching check runs, has neither offload-test.command:<repo> nor offload-test.command. The run then failed StepFailed in resolve-command, about 6 s in, with no log. The PR author sees a red check that nobody can act on.

Take

In webhook mode (no command in the dispatch), a command missing from both keys fails RunSkipped. The dispatcher already concludes that as a neutral check with the reason in its summary (workflow.ts); the reason names offload-test.command:<repo> and offload-test.command. A green check would claim tests passed that never ran; neutral says the run did not apply.

An Action-mode dispatch that passes an empty command still fails StepFailed, because there the caller chose the run and supplied a broken input. Staged mode is unchanged: a declared stage with no command still fails loudly in resolve-command.

The RunSkipped doc comment now covers a repository that never opted in alongside the capacity case.

Key actions

  • runs/offload-test.test.ts: the no-command webhook case expects RunSkipped with the per-repo key in the reason; a new case pins StepFailed for an empty Action-mode command.
  • pnpm typecheck, pnpm lint, and vitest run (2374 passed, 1 skipped).

…heck, not a red one

The pull_request trigger reaches every repo the App is installed on. With no `offload-test.command:<repo>` and no dispatcher-wide default, a webhook dispatch now fails `RunSkipped`, which the dispatcher concludes neutral, naming the key to set. An Action dispatch that passes an empty command still fails StepFailed.
@debuggingfuture
debuggingfuture marked this pull request as ready for review September 22, 2026 06:33

@flaredispatch-fractalboxdev flaredispatch-fractalboxdev Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI code review — ✅ Approve

Risk tier: lite · 0 critical · 0 warnings · 0 suggestions

Reviewers: security 0 · code-quality 0 · performance 0 · documentation 0

No findings.

📋 View full logs & reviewed diff ↗

@debuggingfuture
debuggingfuture merged commit d6784d0 into main Sep 22, 2026
5 checks passed
@debuggingfuture
debuggingfuture deleted the fix/offload-test-unconfigured-neutral branch September 22, 2026 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant