fix(offload-test): a repo with no configured command gets a neutral check, not a red one - #153
Merged
Merged
Conversation
…heck, not a red one The pull_request trigger reaches every repo the App is installed on. With no `offload-test.command:<repo>` and no dispatcher-wide default, a webhook dispatch now fails `RunSkipped`, which the dispatcher concludes neutral, naming the key to set. An Action dispatch that passes an empty command still fails StepFailed.
debuggingfuture
marked this pull request as ready for review
September 22, 2026 06:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A repository that never configured an
offload-testcommand now gets a neutralflare-dispatch/offload-testcheck that names the key to set, instead of a red one.Problem & Insight
The
pull_requesttrigger fires on every non-draft PR in every repository the App is installed on, and itsgatereads only the payload, so nothing can opt a repository out. A repository that runs its tests elsewhere, for example through its own workflow dispatchingcheckruns, has neitheroffload-test.command:<repo>noroffload-test.command. The run then failedStepFailedinresolve-command, about 6 s in, with no log. The PR author sees a red check that nobody can act on.Take
In webhook mode (no
commandin the dispatch), a command missing from both keys failsRunSkipped. The dispatcher already concludes that as aneutralcheck with the reason in its summary (workflow.ts); the reason namesoffload-test.command:<repo>andoffload-test.command. A green check would claim tests passed that never ran; neutral says the run did not apply.An Action-mode dispatch that passes an empty
commandstill failsStepFailed, because there the caller chose the run and supplied a broken input. Staged mode is unchanged: a declared stage with no command still fails loudly inresolve-command.The
RunSkippeddoc comment now covers a repository that never opted in alongside the capacity case.Key actions
runs/offload-test.test.ts: the no-command webhook case expectsRunSkippedwith the per-repo key in the reason; a new case pinsStepFailedfor an empty Action-modecommand.pnpm typecheck,pnpm lint, andvitest run(2374 passed, 1 skipped).