feat(docs): flare-dispatch.fractalbox.dev serves the docs site; the dispatcher moves to flare-dispatch-app - #155
Merged
Merged
Conversation
…te; the dispatcher moves to flare-dispatch-app apps/docs is an Astro Starlight site whose pages are symbolic links to the repo's Markdown (substrate guides, facade reference, run catalog, action READMEs, specs and ADRs). Titles, descriptions and relative links resolve at build time; the build fails on a broken internal link. /llms.txt and /llms-full.txt are generated from the same pages. The dispatcher Worker's custom domain becomes flare-dispatch-app.fractalbox.dev. The install pages' docs links point at pages that exist.
debuggingfuture
marked this pull request as ready for review
September 23, 2026 15:54
There was a problem hiding this comment.
AI code review — 💬 Comment
Risk tier: full · 0 critical · 1 warnings · 0 suggestions
Reviewers: security 1 · performance
1. ⚠️ Warning — Pin GitHub Actions to immutable commit SHAs
📍 .github/workflows/docs.yml:54-56
The production deployment workflow uses mutable tags ('actions/checkout@v4', 'pnpm/action-setup@v4', and 'actions/setup-node@v4'). A compromised upstream release or retag could execute code with access to the Cloudflare deployment credentials. Pin these actions to full commit SHAs and update them deliberately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flare-dispatch.fractalbox.devserves a documentation site built fromapps/docs; the dispatcher Worker (API, GitHub App webhook, dashboard, log viewer) servesflare-dispatch-app.fractalbox.dev.Problem & Insight
The README's Documentation link and the install pages' footer pointed at the dispatcher's own origin, which serves the dashboard, and at paths (
/docs/05-byoc,/docs/prd,/recipes) that exist nowhere. The docs themselves were already here as plain Markdown —apps/docsguides and reference, the run catalog, the action READMEs, the specs and ADRs — but spread across the tree and readable only on GitHub.Take
apps/docs/src/lib/pages.mjstakes titles and descriptions from each file's first heading and paragraph, and rewrites relative links to site URLs — or to GitHub for files that are not pages (source, schemas). The build fails on a broken internal link./llms.txt,/llms-full.txt,robots.txtand the sitemap are generated from the same collection; the hand-writtenapps/docs/llms.txtis gone.apps/docs/wrangler.jsonc).docs.ymlbuilds it on every PR and deploys it onmain, with no path filter because a page can change from any directory.PUBLIC_ORIGIN. Only the install pages' hard-coded docs links change, to pages that exist.Deployer follow-ups
FLAREDISPATCH_ENDPOINTvariable/deployAccess application to the new hostname