Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion RELEASE_NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -86,4 +86,4 @@

## Bug Fixes

<!-- Here goes notable bug fixes that are worth a special mention or explanation -->
* Fixed `EnumParityTest` so protobuf values whose Python member name exists with a different number fail parity checks instead of being treated as unmirrored protobuf values.
15 changes: 10 additions & 5 deletions src/frequenz/client/common/test/enum_parity.py
Original file line number Diff line number Diff line change
Expand Up @@ -215,12 +215,17 @@ def test_proto_enum_matches_enum_value(self, pb_name: str) -> None:
stripped = pb_name.removeprefix(self.name_prefix)
with self._maybe_ignore_deprecation(stripped):
try:
member = self.python_enum(pb_value)
except ValueError:
# It is OK to have new protobuf enum values not yet in the Python
# enum.
named_member = self.python_enum[stripped]
except KeyError:
try:
value_member = self.python_enum(pb_value)
except ValueError:
# It is OK to have new protobuf enum values not yet in the
# Python enum.
return
assert f"{self.name_prefix}{value_member.name}" == pb_name
return
assert member.value == pb_value
assert named_member.value == pb_value

def test_enum_matches_proto_enum_name(self, member: Enum) -> None:
"""Test that all Python enum members have a matching protobuf name.
Expand Down
4 changes: 4 additions & 0 deletions tests/test/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# License: MIT
# Copyright © 2026 Frequenz Energy-as-a-Service GmbH

"""Tests for the test utilities package."""
Loading
Loading