Skip to content

Small, medium priority security fixes - #552

Open
georgelgeback wants to merge 6 commits into
mainfrom
misc-security
Open

Small, medium priority security fixes#552
georgelgeback wants to merge 6 commits into
mainfrom
misc-security

Conversation

@georgelgeback

Copy link
Copy Markdown
Contributor

Told Claude to search for any problems and these ones actually seemed bad enough to fix:

  • Getting all users who hold a certain post now requires you to be a member
  • Add formula escaping to csv export
  • Fix bug which allowed html in stil_id to slip through sometimes (the frontend also escapes it, so it was likely not a big problem)
  • Ads are not done yet, but fixed a bug where anyone could create an ad in somebody else's name

Created regression tests for all of the above except the ad fix, which didn't feel like it needed one. Ideally the tests would be in their respective files for whatever service we are testing, but we have no post tests, no tests of csv export and none for the stil-id serving nor doors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant