ci: scope workflow permissions to jobs instead of workflow level - #323
Closed
xavidop wants to merge 1 commit into
Closed
ci: scope workflow permissions to jobs instead of workflow level#323xavidop wants to merge 1 commit into
xavidop wants to merge 1 commit into
Conversation
zizmor's excessive-permissions audit flags broad top-level permissions blocks in publish-docs.yml and release.yml. Move contents/pages/ id-token/packages/pull-requests permissions to only the jobs that actually need them.
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
permissions:blocks inpublish-docs.ymlandrelease.yml.permissions:scoped to what each job actually needs (e.g. only thedeployjob in publish-docs.yml getspages: write/id-token: write; onlyreleasegetspull-requests: write, etc).This addresses zizmor's
excessive-permissionsfinding, which was still failing PR #316 (actions/setup-java5→6) after #322 fixed the unpinned-actions/template-injection findings — the job fails on any medium/high-severity zizmor finding, not just the "mandatory" ones.Test plan
GitHub Actions Scanshould go green)publish-docs.yml/release.ymlstill deploy/publish correctly on the next run (permissions were narrowed, not removed, for the jobs that need them)