Skip to content

Keep model picker settings visible - #2648

Merged
SawyerHood merged 2 commits into
mainfrom
bb/keep-model-picker-settings-visible-thr_6gjd7ypubb
Aug 28, 2026
Merged

Keep model picker settings visible#2648
SawyerHood merged 2 commits into
mainfrom
bb/keep-model-picker-settings-visible-thr_6gjd7ypubb

Conversation

@SawyerHood

Copy link
Copy Markdown
Collaborator

Human comments

What was wrong

PR #2310 gave the desktop model picker one shared scroll area to remove a nested-scroll failure. That fix also placed Reasoning, Fast mode, and the footer after the complete model catalog. Providers with long catalogs required users to reach the list end before they could change these settings, as #2645 reports.

What changed

ModelReasoningPicker now gives scroll ownership only to the desktop model list. The Reasoning, Fast mode, and footer sections remain outside that scroll area. The popover uses the smaller available height from Radix and the desktop viewport, with outer overflow hidden. The mobile drawer remains unchanged.

This change addresses the list layout in #2645. It does not change the close behavior or add favorite-model shortcuts. No wire or CLI surface changed.

How you verified

  • Updated the desktop regression test to require exactly one scroll area, owned by the model list. The test fails on the prior shared-scroll layout because that scroll area also contains Reasoning.
  • Checked the picker story at 1000x520 and 1000x400. The model list scrolls, Reasoning keeps its position, and the popover stays inside the viewport.
  • Ran pnpm exec turbo run test typecheck lint build --filter=@bb/app: 442 test files passed with 3,493 tests passed and three skipped.
  • Ran the focused picker test again: 28 tests passed.

Addresses #2645

AGENT GENERATED

@SawyerHood
SawyerHood merged commit 06ecd48 into main Aug 28, 2026
15 checks passed
@SawyerHood
SawyerHood deleted the bb/keep-model-picker-settings-visible-thr_6gjd7ypubb branch August 28, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant