Keep model picker settings visible - #2648
Merged
SawyerHood merged 2 commits intoAug 28, 2026
Merged
Conversation
SawyerHood
deleted the
bb/keep-model-picker-settings-visible-thr_6gjd7ypubb
branch
August 28, 2026 15:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
PR #2310 gave the desktop model picker one shared scroll area to remove a nested-scroll failure. That fix also placed Reasoning, Fast mode, and the footer after the complete model catalog. Providers with long catalogs required users to reach the list end before they could change these settings, as #2645 reports.
What changed
ModelReasoningPickernow gives scroll ownership only to the desktop model list. The Reasoning, Fast mode, and footer sections remain outside that scroll area. The popover uses the smaller available height from Radix and the desktop viewport, with outer overflow hidden. The mobile drawer remains unchanged.This change addresses the list layout in #2645. It does not change the close behavior or add favorite-model shortcuts. No wire or CLI surface changed.
How you verified
pnpm exec turbo run test typecheck lint build --filter=@bb/app: 442 test files passed with 3,493 tests passed and three skipped.Addresses #2645