fix: authenticate child resource listings - #421
Open
Bortlesboat wants to merge 1 commit into
Open
Conversation
Welcome, @Bortlesboat!Thanks for your first contribution! Before we proceed with the review, please sign the Fiduciary License Agreement: Once signed, this PR will be automatically updated. |
Thanks, @Bortlesboat! 🎉Your CLA has been signed and is now on file. We'll proceed with the review shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Child-resource listing requests now send the configured API key, preventing missing-header 401 failures across all twelve inherited
find_allmethods. The regression test exercises each public entry point with pagination and checks the outgoing headers and returned metadata.Credit to telesoho for the original authentication fix. This PR keeps the existing
timetourparameter and timeout behavior; changing those needs a separate compatibility decision.Related: #410, #385.
Validation: all 12 new cases fail before the fix;
python -m pytest testspasses all 461 tests after it. Repository-wide Ruff lint and formatting checks also pass. Tested on Windows with Python 3.12.9 and HTTPX 0.28.1; HTTP requests are mocked.AI-assisted implementation and local verification.