build: bump keepcurrent for fileSource pre-size fix (follow-up)#673
Merged
Conversation
Pulls in getlantern/keepcurrent#10, which makes fileSource size-aware so geo's startup InitFrom(FromFile) read of the cached ~75MB mmdb stops churning through io.ReadAll's realloc staircase. Completes the memory fix started in #671 (which covered the web-sync path). NOTE: pinned to the keepcurrent PR-head commit; re-pin to the squashed main commit after keepcurrent#10 merges (go get keepcurrent@<main> && go mod tidy).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #671. Pulls in keepcurrent#10.
Why
#671 deployed the keepcurrent memory fix, but pprof on the rolled-out fleet showed a residual
io.ReadAlldoubling churn fromgeo's startupInitFrom(FromFile(...))read of the cached ~75MB MaxMind mmdb — keepcurrent'sfileSourcewas the one source #9 didn't make size-aware. keepcurrent#10 closes that.What
go get keepcurrent@<#10> && go mod tidy. keepcurrent stays indirect; no first-party code change. Build is clean (geo-consuming packages incl. thehttp-proxycommand compile; only the pre-existinganacrolix/go-libutpcgo issue, unrelated).go get github.com/getlantern/keepcurrent@<main-sha> && go mod tidy) before merging this. See the rollout handoff.