fix(pipedream): shared pipeline-level env vars no longer overridable at trigger time - #103
Merged
Merged
Conversation
Grouped pipelines demoted every service env var to stage or job level, so variables like SKIP_CANARY_CHECKS disappeared from GoCD's Trigger with options dialog and could no longer be overridden per run. Pipeline-level vars identical across all regions in a group now stay at pipeline level.
mchen-sentry
marked this pull request as ready for review
September 10, 2026 22:48
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
kenzoengineer
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the grouped pipedream update, every env var a service sets gets pushed down to the stage or job level, so nothing is left at the pipeline level.
GoCD's "Trigger with options" dialog only shows pipeline-level vars, which is why things like
SKIP_CANARY_CHECKSdisappeared from it and can't be flipped per run anymore.The grouping change only checked that the scripts still see the same values at runtime (they do, since GoCD resolves job > stage > pipeline), and missed that the dialog reads from a different place.
Let's keep vars that are the same across all regions at the pipeline level so they show up in the dialog again.