Skip to content

feat(upload): Revert use of multipart uploads - #6324

Open
jjbayer wants to merge 7 commits into
masterfrom
feat/upload-no-multipart
Open

feat(upload): Revert use of multipart uploads#6324
jjbayer wants to merge 7 commits into
masterfrom
feat/upload-no-multipart

Conversation

@jjbayer

@jjbayer jjbayer commented Aug 25, 2026

Copy link
Copy Markdown
Member

Multipart is getting replaced by resumable uploads on the Objectstore side. Remove its traces.

Fixes INGEST-1048

@linear-code

linear-code Bot commented Aug 25, 2026

Copy link
Copy Markdown

INGEST-1048

@jjbayer
jjbayer marked this pull request as ready for review August 27, 2026 13:29
@jjbayer
jjbayer requested a review from a team as a code owner August 27, 2026 13:29

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 5daa4f1. Configure here.

response = upload_something(relay, project_id, project_key)

assert response.status_code == 504
assert response.status_code == 500 # not 504

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Timeout test no longer checks timeouts

Medium Severity

test_objectstore_timeout now sets timeout instead of stream_timeout, so the TUS stream never hits the one-second deadline. The mock then raises NotImplementedError, and the test asserts 500 rather than the previous 504 gateway timeout.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 5daa4f1. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant