Repository navigation
Conversation
giortzisg
force-pushed
the
scopes/scope-merge
branch
from
July 23, 2026 08:45
8f6a8b4 to
e509cb6
Compare
giortzisg
marked this pull request as ready for review
July 23, 2026 08:51
giortzisg
force-pushed
the
scopes/scope-merge
branch
from
July 30, 2026 20:45
e509cb6 to
5ea0d02
Compare
giortzisg
force-pushed
the
scopes/scope-merge
branch
from
August 4, 2026 15:25
5ea0d02 to
2905cce
Compare
giortzisg
force-pushed
the
scopes/scope-merge
branch
2 times, most recently
from
August 5, 2026 09:59
8b46a73 to
b3bd79f
Compare
giortzisg
force-pushed
the
scopes/scope-merge
branch
from
August 10, 2026 11:28
b3bd79f to
5ab473f
Compare
giortzisg
force-pushed
the
scopes/scope-merge
branch
from
August 10, 2026 11:36
5ab473f to
a27e5e5
Compare
giortzisg
force-pushed
the
scopes/scope-merge
branch
2 times, most recently
from
August 12, 2026 12:11
a32be8d to
af060b8
Compare
giortzisg
force-pushed
the
scopes/scope-merge
branch
from
August 13, 2026 12:27
5146682 to
80b661b
Compare
giortzisg
force-pushed
the
scopes/scope-merge
branch
from
August 13, 2026 12:38
80b661b to
f1ba13c
Compare
giortzisg
force-pushed
the
scopes/scope-merge
branch
from
September 7, 2026 11:49
ffd5441 to
5d18fe6
Compare
giortzisg
force-pushed
the
scopes/scope-merge
branch
from
September 16, 2026 09:14
5d18fe6 to
dee2303
Compare
giortzisg
force-pushed
the
scopes/scope-merge
branch
from
September 17, 2026 08:38
dee2303 to
51abc52
Compare
giortzisg
removed this pull request from stack #1420
September 18, 2026 11:17
giortzisg
force-pushed
the
scopes/scope-merge
branch
from
September 18, 2026 11:18
51abc52 to
e5ae7c8
Compare
giortzisg
added this pull request to stack #1433
September 18, 2026 11:22
giortzisg
force-pushed
the
scopes/scope-merge
branch
from
September 29, 2026 09:32
e5ae7c8 to
be0de42
Compare
giortzisg
force-pushed
the
scopes/scope-merge
branch
from
September 29, 2026 11:11
be0de42 to
8cb9cac
Compare
giortzisg
removed this pull request from stack #1433
September 29, 2026 11:14
giortzisg
added this pull request to stack #1437
September 29, 2026 11:18
giortzisg
force-pushed
the
scopes/scope-merge
branch
from
September 29, 2026 11:19
8cb9cac to
da59ff8
Compare
giortzisg
force-pushed
the
scopes/scope-merge
branch
from
October 8, 2026 12:43
da59ff8 to
993b027
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 993b027. Configure here.
Apply the single scope selected by the capture context directly to events, preserve event precedence, enforce breadcrumb limits, and run request processing and event processors after releasing the scope lock. Preserve explicitly supplied event and scope trace contexts, and retain dynamic sampling context only when it belongs to the selected trace. Event values now take precedence over scope values during capture, context scopes replace the global scope, and scope breadcrumbs and attachments are applied before event-specific values.
giortzisg
force-pushed
the
scopes/scope-merge
branch
from
October 9, 2026 08:36
993b027 to
a631d7f
Compare
giortzisg
removed this pull request from stack #1437
October 9, 2026 08:37
giortzisg
added this pull request to stack #1452
October 9, 2026 08:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This adds the scope merging mechanism by allocating a
captureStateobject and copying all needed event attributes in place. This removes taking multiple scope clones on every capture.The PR also includes breaking changes around
EventModifier. TheEventModifierwas an agnostic modifier that was passed onApplyToEvent. This duplicated the EventProcessor behavior and also complicated the scope merging mechanism, since we need to have a concrete*Scopetype to merge the scopes. Furthermore, there is no documented behavior or signature for anyEventModifierand this seems to be just the first archaic way to modify events beforeEventProcessorandBeforeSendhooks where a thing. Thus decided to remove this and have a concrete*Scopepassed onApplyToEvent. This behavior aligns with other sdks that pass a concrete scope.This affects the public API with all the
CaptureXmethods now requiring a concrete scope to be passed, but further scope changes in the stack also change theCaptureXAPIs to work withcontext.Context, so this change seems acceptable. Functionality isn't really removed but just shifted toBeforeSendhooks as intended.Issues
Changelog Entry Instructions
To add a custom changelog entry, uncomment the section above. Supports:
For more details: custom changelog entries
Reminders
feat:,fix:,ref:,meta:)