Repository navigation
Conversation
giortzisg
added this pull request to stack #1433
September 18, 2026 11:22
giortzisg
force-pushed
the
scopes/api-cleanup
branch
2 times, most recently
from
September 29, 2026 11:11
6845525 to
80ce9b8
Compare
giortzisg
removed this pull request from stack #1433
September 29, 2026 11:14
giortzisg
added this pull request to stack #1437
September 29, 2026 11:18
giortzisg
force-pushed
the
scopes/api-cleanup
branch
from
September 29, 2026 11:19
80ce9b8 to
a8d7daa
Compare
giortzisg
force-pushed
the
scopes/api-cleanup
branch
from
September 29, 2026 13:29
a8d7daa to
24fb93c
Compare
giortzisg
force-pushed
the
scopes/api-cleanup
branch
from
September 29, 2026 13:35
24fb93c to
3bbda35
Compare
giortzisg
force-pushed
the
scopes/api-cleanup
branch
from
October 8, 2026 12:43
3bbda35 to
1862cad
Compare
giortzisg
force-pushed
the
scopes/api-cleanup
branch
from
October 8, 2026 14:17
1862cad to
50eced9
Compare
This removes the obsolete MockScope and metric scope overrides. Also simplifies the tracing API to keep only ContinueTrace as the public continuation option.
giortzisg
force-pushed
the
scopes/api-cleanup
branch
from
October 9, 2026 08:36
50eced9 to
3b90464
Compare
giortzisg
removed this pull request from stack #1437
October 9, 2026 08:37
giortzisg
added this pull request to stack #1452
October 9, 2026 08:37
szokeasaurusrex
approved these changes
Oct 9, 2026
|
|
||
| `GetTraceparent` returns Sentry's `sentry-trace` header value. Use | ||
| `GetTraceparentW3C` for the W3C `traceparent` header value. | ||
|
|
Member
There was a problem hiding this comment.
l: I am not sure I would put all of this in the top-level README.md.
In any case, I would also add a section division at the end of this new section, as I don't think the things below belong under "Context and Scopes"
|
|
||
| // GetTraceparent returns the Sentry trace header value carried by ctx. | ||
| // GetTraceparent returns the sentry-trace header value carried by ctx. | ||
| // It is not the W3C traceparent header; use GetTraceparentW3C for that value. |
Member
There was a problem hiding this comment.
l: I find the existing wording a bit confusing; it also makes it seem like we are assuming our users will confuse the two.
I would rather we just clarify that the headers are distinct, and tell users where they obtain the W3C traceparent header.
Suggested change
| // It is not the W3C traceparent header; use GetTraceparentW3C for that value. | |
| // The `sentry-trace` header is distinct from the W3C traceparent header, which | |
| // can be obtained using GetTraceparentW3C. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issues
Changelog Entry Instructions
To add a custom changelog entry, uncomment the section above. Supports:
For more details: custom changelog entries
Reminders
feat:,fix:,ref:,meta:)Stack created with GitHub Stacks CLI • Give Feedback 💬