Repository navigation
Conversation
Allow serializers to suppress debug logging for individual calls and disable it while calculating serialized byte sizes. Preserve compatibility for custom serializers through a default interface implementation. Fixes #4946 Co-Authored-By: Claude <noreply@anthropic.com>
📲 Install BuildsAndroid
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Add an
ISerializer.serializeoverload that accepts anenableLoggingflag. The default implementation delegates to the existing overload to preserve compatibility with custom serializers, whileJsonSerializerhonors the flag.Use the new overload from
JsonSerializationUtils.byteSizeOfwith logging disabled so byte-size calculations do not emit duplicateSerializing objectdebug messages.💡 Motivation and Context
Calculating serialized byte sizes currently causes full objects, including log envelopes, to be written to debug logs. This produces significant log spam even though serialization is only being performed for accounting or size checks.
Resolves #4946
Refs JAVA-261
💚 How did you test it?
./gradlew :sentry:test --tests io.sentry.JsonSerializerTest --tests io.sentry.util.JsonSerializationUtilsTest./gradlew :sentry:apiCheck./gradlew spotlessApply apiDump📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
None.