Skip to content

feat(core): Rename queryParams to urlQueryParams#22217

Open
s1gr1d wants to merge 2 commits into
developfrom
sig/rename-urlQueryParams
Open

feat(core): Rename queryParams to urlQueryParams#22217
s1gr1d wants to merge 2 commits into
developfrom
sig/rename-urlQueryParams

Conversation

@s1gr1d

@s1gr1d s1gr1d commented Jul 13, 2026

Copy link
Copy Markdown
Member

Update name of queryParams to urlQueryParams to reduce ambiguity with other query types.

We can just use urlQueryParams everywhere in the code as we resolve the option once and then use just the new value:

urlQueryParams: dc.urlQueryParams ?? dc.queryParams ?? base.urlQueryParams,

Develop Docs PR: getsentry/sentry-docs#18703
The PR is not merged (as of now) but this change was already discussed to be made.

@s1gr1d s1gr1d requested a review from a team as a code owner July 13, 2026 09:17
@s1gr1d s1gr1d requested review from chargome, mydea and nicohrubec and removed request for a team July 13, 2026 09:17
@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 27.61 kB +0.03% +7 B 🔺
@sentry/browser - with treeshaking flags 26.05 kB +0.02% +5 B 🔺
@sentry/browser (incl. Tracing) 46.36 kB +0.02% +8 B 🔺
@sentry/browser (incl. Tracing + Span Streaming) 48.15 kB +0.03% +11 B 🔺
@sentry/browser (incl. Tracing, Profiling) 51.14 kB +0.01% +5 B 🔺
@sentry/browser (incl. Tracing, Replay) 85.63 kB +0.01% +7 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 75.26 kB +0.01% +6 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 90.34 kB +0.01% +5 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 103 kB +0.01% +7 B 🔺
@sentry/browser (incl. Feedback) 44.79 kB +0.02% +7 B 🔺
@sentry/browser (incl. sendFeedback) 32.41 kB +0.03% +9 B 🔺
@sentry/browser (incl. FeedbackAsync) 37.53 kB +0.03% +8 B 🔺
@sentry/browser (incl. Metrics) 28.69 kB +0.03% +7 B 🔺
@sentry/browser (incl. Logs) 28.93 kB +0.02% +5 B 🔺
@sentry/browser (incl. Metrics & Logs) 29.62 kB +0.03% +7 B 🔺
@sentry/react 29.4 kB +0.03% +7 B 🔺
@sentry/react (incl. Tracing) 48.63 kB +0.03% +13 B 🔺
@sentry/vue 33.04 kB +0.02% +6 B 🔺
@sentry/vue (incl. Tracing) 48.34 kB +0.02% +6 B 🔺
@sentry/svelte 27.63 kB +0.03% +8 B 🔺
CDN Bundle 30.01 kB +0.03% +8 B 🔺
CDN Bundle (incl. Tracing) 48.34 kB +0.02% +8 B 🔺
CDN Bundle (incl. Logs, Metrics) 31.59 kB +0.02% +6 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) 49.66 kB +0.03% +12 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) 70.82 kB +0.01% +7 B 🔺
CDN Bundle (incl. Tracing, Replay) 85.84 kB +0.02% +9 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 87.17 kB +0.01% +8 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 91.65 kB +0.01% +9 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 92.92 kB +0.01% +6 B 🔺
CDN Bundle - uncompressed 89.36 kB +0.04% +33 B 🔺
CDN Bundle (incl. Tracing) - uncompressed 146.11 kB +0.03% +33 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed 94.06 kB +0.04% +33 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 150.08 kB +0.03% +33 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 218.79 kB +0.02% +33 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 265.31 kB +0.02% +33 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 269.27 kB +0.02% +33 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 279.01 kB +0.02% +33 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 282.96 kB +0.02% +33 B 🔺
@sentry/nextjs (client) 51.17 kB +0.02% +6 B 🔺
@sentry/sveltekit (client) 46.8 kB +0.02% +7 B 🔺
@sentry/core/server 78.43 kB +0.02% +10 B 🔺
@sentry/core/browser 64.78 kB +0.02% +9 B 🔺
@sentry/node-core 62.73 kB +0.02% +10 B 🔺
@sentry/node 125.36 kB +0.01% +10 B 🔺
@sentry/node (incl. diagnostics channel injection) 139.65 kB +0.02% +14 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 69.96 kB - -
@sentry/node/light 50.74 kB +0.03% +13 B 🔺
@sentry/node - without tracing 74.05 kB +0.02% +12 B 🔺
@sentry/aws-serverless 83.27 kB +0.02% +14 B 🔺
@sentry/cloudflare (withSentry) - minified 181.51 kB +0.02% +36 B 🔺
@sentry/cloudflare (withSentry) 449.07 kB +0.03% +96 B 🔺

View base workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant