Skip to content

Expose Attributes type definition in public place #6970

Closed

Description

See getsentry/snuba#8245 (comment).
It seems that users currently have to import with from sentry_sdk._types import Attributes

Activity

  1. linear-code commented on Jul 31, 2026

    @linear-code
  2. sansynx commented on Oct 13, 2026

    @sansynx
    Contributor

    I checked current master, and Attributes is still only defined in the private _types module. Could I take this on by exporting it from sentry_sdk.types, following the existing public type exports? I would add import and type-check coverage as well

  3. alexander-alderman-webb commented on Oct 13, 2026

    @alexander-alderman-webb
    CollaboratorAuthor

    Sure feel free to put up a PR!

  4. moved this from Waiting for: Product Owner to No status in GitHub Issues with 👀 3on Oct 13, 2026
  5. sansynx commented on Oct 13, 2026

    @sansynx
    Contributor

    Opened #8019 for the public Attributes export. The focused tests, SDK typecheck and lint checks pass locally

  6. moved this to Waiting for: Product Owner in GitHub Issues with 👀 3on Oct 13, 2026
  7. added a commit that references this issue on Oct 14, 2026
    916942d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions