Skip to content

test(quart): Fix flake caused by flushing the span batcher on segment end - #7185

Merged
alexander-alderman-webb merged 1 commit into
masterfrom
webb/quart/fix-flake
Aug 13, 2026
Merged

alexander-alderman-webb merged 1 commit into
masterfrom
webb/quart/fix-flake

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Aug 13, 2026 •

Copy link
Copy Markdown
Collaborator

Description

The background flush on segment end is asynchronous.

The error is

=================================== FAILURES ===================================
_ test_span_streaming_quart_auth_user_id_data_collection[dc_default_user_info] _
tests/integrations/quart/test_quart.py:1223: in test_span_streaming_quart_auth_user_id_data_collection
    assert segment["attributes"]["user.id"] == "42"
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E   KeyError: 'user.id'

Issues

Reminders

@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner August 13, 2026 08:46
@github-actions

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 112463 passed | ⏭️ 6759 skipped | Total: 119222 | Pass Rate: 94.33% | Execution Time: 394m 59s

📊 Comparison with Base Branch

Metric Change
Total Tests —
Passed Tests —
Failed Tests —
Skipped Tests —

✨ No test changes detected

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2485 uncovered lines.
❌ Project coverage is 90.2%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
- Coverage    90.22%    90.20%    -0.02%
==========================================
  Files          193       193         —
  Lines        25361     25361         —
  Branches      9302      9302         —
==========================================
+ Hits         22880     22876        -4
- Misses        2481      2485        +4
- Partials      1436      1432        -4

Generated by Codecov Action

@alexander-alderman-webb alexander-alderman-webb changed the title test(quart): Fix flake due to flushing on segment end test(quart): Fix flake caused by flushing the span batcher on segment end Aug 13, 2026
@alexander-alderman-webb
alexander-alderman-webb merged commit 4ada8f1 into master Aug 13, 2026
144 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/quart/fix-flake branch August 13, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants