Skip to content

test(arq, celery, client, gcp, sanic): Drop redundant data_collection={} from tests #7910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pabloDeputter merged 1 commit into from
Oct 7, 2026
Merged

test(arq, celery, client, gcp, sanic): Drop redundant data_collection={} from tests #7910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions tests/integrations/arq/test_arq.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ def inner(
sentry_init_kwargs = {
"integrations": [ArqIntegration()],
"traces_sample_rate": 1.0,
"data_collection": {},
}
sentry_init_kwargs.update(init_kwargs or {})
sentry_init(**sentry_init_kwargs)
Expand Down Expand Up @@ -111,7 +110,6 @@ def inner(
sentry_init_kwargs = {
"integrations": [ArqIntegration()],
"traces_sample_rate": 1.0,
"data_collection": {},
}
sentry_init_kwargs.update(init_kwargs or {})
sentry_init(**sentry_init_kwargs)
Expand Down Expand Up @@ -162,7 +160,6 @@ def inner(
sentry_init_kwargs = {
"integrations": [ArqIntegration()],
"traces_sample_rate": 1.0,
"data_collection": {},
}
sentry_init_kwargs.update(init_kwargs or {})
sentry_init(**sentry_init_kwargs)
Expand Down
8 changes: 4 additions & 4 deletions tests/integrations/celery/test_update_celery_task_headers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def test_monitor_beat_tasks_with_headers(monitor_beat_tasks):


def test_span_with_segment(sentry_init):
sentry_init(traces_sample_rate=1.0, data_collection={})
sentry_init(traces_sample_rate=1.0)
headers = {}
monitor_beat_tasks = False

Expand All @@ -90,7 +90,7 @@ def test_span_with_segment(sentry_init):


def test_span_with_segment_custom_headers(sentry_init):
sentry_init(traces_sample_rate=1.0, data_collection={})
sentry_init(traces_sample_rate=1.0)
headers = {
"baggage": BAGGAGE_VALUE,
"sentry-trace": SENTRY_TRACE_VALUE,
Expand Down Expand Up @@ -133,7 +133,7 @@ def test_celery_trace_propagation_default(sentry_init, monitor_beat_tasks):
The Celery integration has its own mechanism to propagate traces:
https://docs.sentry.io/platforms/python/integrations/celery/#distributed-traces
"""
sentry_init(data_collection={})
sentry_init()

headers = {}
span = None
Expand Down Expand Up @@ -169,7 +169,7 @@ def test_celery_trace_propagation_traces_sample_rate(
The Celery integration has its own mechanism to propagate traces:
https://docs.sentry.io/platforms/python/integrations/celery/#distributed-traces
"""
sentry_init(traces_sample_rate=traces_sample_rate, data_collection={})
sentry_init(traces_sample_rate=traces_sample_rate)

headers = {}
span = None
Expand Down
2 changes: 1 addition & 1 deletion tests/integrations/gcp/test_gcp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,7 +613,7 @@ def cloud_function(functionhandler, event):
+ FUNCTIONS_PRELUDE
+ dedent(
"""
init_sdk(traces_sample_rate=1.0, data_collection={})
init_sdk(traces_sample_rate=1.0)
gcp_functions.worker_v1.FunctionHandler.invoke_user_function(functionhandler, event)
"""
)
Expand Down
2 changes: 1 addition & 1 deletion tests/integrations/sanic/test_sanic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ def reusable_client(app):


def test_request_data(sentry_init, app, capture_events):
sentry_init(integrations=[SanicIntegration()], data_collection={})
sentry_init(integrations=[SanicIntegration()])
events = capture_events()

c = get_client(app)
Expand Down
2 changes: 1 addition & 1 deletion tests/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -953,7 +953,7 @@ def test_dict_changed_during_iteration(sentry_init, capture_events):

See https://github.com/getsentry/sentry-python/pull/298 for discussion
"""
sentry_init(data_collection={})
sentry_init()
events = capture_events()

class TooSmartClass:
Expand Down
Loading