Skip to content

chore(mcp): Stop setting mcp.tool.result.content_count - #7911

Merged
alexander-alderman-webb merged 1 commit into
major/3.0from
webb/mcp/remove-content-count
Oct 7, 2026
Merged

alexander-alderman-webb merged 1 commit into
major/3.0from
webb/mcp/remove-content-count

Conversation

@alexander-alderman-webb

Copy link
Copy Markdown
Collaborator

Description

Stop setting mcp.tool.result.content_count since the length can be determined from the value of the gen_ai.tool.call.result attribute.

See deprecation in getsentry/sentry-conventions@b06e641

Issues

Reminders

@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner October 7, 2026 07:24
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 54978 passed | ❌ 1 failed | ⏭️ 2727 skipped | Total: 57706 | Pass Rate: 95.27% | Execution Time: 153m 22s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -82679
Passed Tests 📉 -78184
Failed Tests —
Skipped Tests 📉 -4495

➕ New Tests (1)

View new tests
  • test_cache_spans_item_size
    • File: tests.integrations.django.test_cache_module
    • Status: ❌ Failing

➖ Removed Tests (1)

View removed tests
  • test_cache_spans_decorator[True]
    • File: tests.integrations.django.test_cache_module

❌ Failed Tests

test_cache_spans_item_size

File: tests.integrations.django.test_cache_module
Suite: py3.14-django-v5.2.17
Error: tests/integrations/django/test_cache_module.py:546: in test_cache_spans_item_size assert not spans[0]["attributes"]["cache.hit"] E assert not True

Stack Trace
tests/integrations/django/test_cache_module.py:546: in test_cache_spans_item_size
    assert not spans[0]["attributes"]["cache.hit"]
E   assert not True

✅ Patch coverage is 100.00%. Project has 2061 uncovered lines.
❌ Project coverage is 90.03%. Comparing base (25a4a32) to head (e8dfa37).

Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.38%    90.03%    -0.35%
==========================================
  Files          202       185       -17
  Lines        26552     20672     -5880
  Branches      9858      7114     -2744
==========================================
+ Hits         23997     18611     -5386
- Misses        2555      2061      -494
- Partials      1487      1216      -271

Generated by Codecov Action

@alexander-alderman-webb
alexander-alderman-webb merged commit f589a72 into major/3.0 Oct 7, 2026
145 of 147 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/mcp/remove-content-count branch October 7, 2026 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants