Skip to content

fix(celery): Don't set span status to error on control flow exception - #7912

Merged
sentrivana merged 2 commits into
major/3.0from
ivana/major/celery-control-flow-exc
Oct 7, 2026
Merged

sentrivana merged 2 commits into
major/3.0from
ivana/major/celery-control-flow-exc

Conversation

@sentrivana

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 55423 passed | ❌ 1 failed | ⏭️ 2727 skipped | Total: 58151 | Pass Rate: 95.31% | Execution Time: 150m 6s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -82234
Passed Tests 📉 -77739
Failed Tests —
Skipped Tests 📉 -4495

➖ Removed Tests (1)

View removed tests
  • test_cache_spans_decorator[True]
    • File: tests.integrations.django.test_cache_module

✅ Patch coverage is 100.00%. Project has 2060 uncovered lines.
❌ Project coverage is 90.03%. Comparing base (8e91a17) to head (0112285).

Files with missing lines (1)
File Patch % Lines
sentry_sdk/integrations/celery/init.py 100.00% ⚠️ 1 partials
Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.37%    90.03%    -0.34%
==========================================
  Files          202       185       -17
  Lines        26552     20671     -5881
  Branches      9858      7116     -2742
==========================================
+ Hits         23997     18611     -5386
- Misses        2555      2060      -495
- Partials      1487      1215      -272

Generated by Codecov Action

@sentrivana
sentrivana marked this pull request as ready for review October 7, 2026 09:41
@sentrivana
sentrivana requested a review from a team as a code owner October 7, 2026 09:41
@sentrivana
sentrivana merged commit e7a481c into major/3.0 Oct 7, 2026
145 of 147 checks passed
@sentrivana
sentrivana deleted the ivana/major/celery-control-flow-exc branch October 7, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants