Skip to content

testing merge - #7914

Merged
sentrivana merged 2 commits into
major/3.0from
ivana/major/test-merge-8
Oct 7, 2026
Merged

sentrivana merged 2 commits into
major/3.0from
ivana/major/test-merge-8

Conversation

@sentrivana

Copy link
Copy Markdown
Collaborator

Description

Issues

Reminders

faizansaiyed123 and others added 2 commits October 7, 2026 08:10
Ref #7753

This separates the active-thread/profiler bookkeeping from the
FastAPI-specific request handling.

Changes:
- Centralize active-thread updates in the Starlette integration.
- Provide a Starlette sync-handler wrapper so active-thread metadata is
updated in the thread that actually executes a synchronous handler.
- Reuse that wrapper from the FastAPI integration.
- Preserve both static transaction and span-streaming behavior.

The follow-up FastAPI PR uses this Starlette helper while replacing the
private FastAPI request-handler patch with a global dependency.
@sentrivana
sentrivana merged commit 0a75283 into major/3.0 Oct 7, 2026
143 of 144 checks passed
@sentrivana
sentrivana deleted the ivana/major/test-merge-8 branch October 7, 2026 08:53
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 55339 passed | ❌ 1 failed | ⏭️ 2727 skipped | Total: 58067 | Pass Rate: 95.3% | Execution Time: 154m 13s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -75664
Passed Tests 📉 -71261
Failed Tests 📈 +1
Skipped Tests 📉 -4404

➕ New Tests (1)

View new tests
  • test_cache_spans_item_size
    • File: tests.integrations.django.test_cache_module
    • Status: ❌ Failing

❌ Failed Tests

test_cache_spans_item_size

File: tests.integrations.django.test_cache_module
Suite: py3.11-django-v4.2.30
Error: tests/integrations/django/test_cache_module.py:546: in test_cache_spans_item_size assert not spans[0]["attributes"]["cache.hit"] E assert not True

Stack Trace
tests/integrations/django/test_cache_module.py:546: in test_cache_spans_item_size
    assert not spans[0]["attributes"]["cache.hit"]
E   assert not True

✅ Patch coverage is 93.33%. Project has 2062 uncovered lines.
❌ Project coverage is 90.03%. Comparing base (f589a72) to head (0a75283).

Files with missing lines (1)
File Patch % Lines
sentry_sdk/integrations/starlette.py 92.86% ⚠️ 1 Missing and 2 partials
Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.37%    90.03%    -0.34%
==========================================
  Files          202       185       -17
  Lines        26547     20673     -5874
  Branches      9852      7114     -2738
==========================================
+ Hits         23990     18611     -5379
- Misses        2557      2062      -495
- Partials      1496      1216      -280

Generated by Codecov Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants