Repository navigation
test: Remove pytest.mark.forked from some tests in tests_basics - #7917
Merged
Merged
Conversation
Replace process forking with in-process cleanup. - Add a `restore_global_event_processors` fixture that restores `scope.global_event_processors` after tests that reset integrations, preventing duplicate processors (e.g. DedupeIntegration) from leaking between tests. - Group the TracingTestClass tracing tests into a class whose setup/teardown restores the `static` and `class_` attributes that `functions_to_trace` patches. Refs PY-2637 Refs #6949
ericapisani
marked this pull request as ready for review
October 7, 2026 12:36
ericapisani
marked this pull request as draft
October 7, 2026 12:38
ericapisani
marked this pull request as ready for review
October 7, 2026 12:39
Contributor
Codecov Results 📊✅ 55393 passed | ❌ 1 failed | ⏭️ 2727 skipped | Total: 58121 | Pass Rate: 95.31% | Execution Time: 151m 18s ✅ Patch coverage is 100.00%. Project has 2060 uncovered lines. Coverage diff@@ Coverage Diff @@
## master #PR +/-##
==========================================
- Coverage 90.37% 90.03% -0.34%
==========================================
Files 202 185 -17
Lines 26552 20670 -5882
Branches 9854 7114 -2740
==========================================
+ Hits 23995 18610 -5385
- Misses 2557 2060 -497
- Partials 1495 1214 -281Generated by Codecov Action |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e27897b. Configure here.
ericapisani
marked this pull request as draft
October 7, 2026 12:49
the forked process for test_integrations. Will try and tackle this separately.
ericapisani
changed the title
pytest.mark.forked from test_basics testspytest.mark.forked from some tests in tests_basics
ericapisani
marked this pull request as ready for review
October 7, 2026 15:31
alexander-alderman-webb
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Group the TracingTestClass tracing tests into a class whose setup/teardown restores the
staticandclass_attributes thatfunctions_to_tracepatches.Resolves warnings like these https://github.com/getsentry/sentry-python/actions/runs/37602693189/job/112730646420#step:6:3739
Refs PY-2637
Refs #6949