Skip to content

chore: Replace deprecated view.response.render op with view.render - #7962

Merged
alexander-alderman-webb merged 3 commits into
major/3.0from
webb/view.render
Oct 12, 2026
Merged

alexander-alderman-webb merged 3 commits into
major/3.0from
webb/view.render

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Contributes to #7950

See getsentry/sentry-conventions#700

Issues

Reminders

@alexander-alderman-webb alexander-alderman-webb changed the title chore: Deprecate view.response.render with view.render chore: Deprecate view.response.render with view.render Oct 12, 2026
@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 55723 passed | ❌ 2 failed | ⏭️ 2872 skipped | Total: 58597 | Pass Rate: 95.1% | Execution Time: 151m 41s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -79240
Passed Tests 📉 -74837
Failed Tests 📈 +1
Skipped Tests 📉 -4404

➕ New Tests (2)

View new tests
  • test_cache_spans_item_size
    • File: tests.integrations.django.test_cache_module
    • Status: ❌ Failing
  • test_cache_spans_item_size
    • File: tests.integrations.django.test_cache_module
    • Status: ❌ Failing

➖ Removed Tests (1)

View removed tests
  • test_no_integration[False-False]
    • File: tests.integrations.litellm.test_litellm

❌ Failed Tests

test_cache_spans_item_size

File: tests.integrations.django.test_cache_module
Suite: py3.12-django-v4.2.30
Error: tests/integrations/django/test_cache_module.py:546: in test_cache_spans_item_size assert not spans[0]["attributes"]["cache.hit"] E assert not True

Stack Trace
tests/integrations/django/test_cache_module.py:546: in test_cache_spans_item_size
    assert not spans[0]["attributes"]["cache.hit"]
E   assert not True

test_cache_spans_item_size

File: tests.integrations.django.test_cache_module
Suite: py3.12-django-v6.1.1
Error: tests/integrations/django/test_cache_module.py:546: in test_cache_spans_item_size assert not spans[0]["attributes"]["cache.hit"] E assert not True

Stack Trace
tests/integrations/django/test_cache_module.py:546: in test_cache_spans_item_size
    assert not spans[0]["attributes"]["cache.hit"]
E   assert not True

✅ Patch coverage is 100.00%. Project has 2070 uncovered lines.
❌ Project coverage is 90.1%. Comparing base (a0689e1) to head (cb9ae69).

Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.28%    90.10%    -0.18%
==========================================
  Files          202       193        -9
  Lines        26639     20901     -5738
  Branches      9926      7206     -2720
==========================================
+ Hits         24050     18831     -5219
- Misses        2589      2070      -519
- Partials      1509      1232      -277

Generated by Codecov Action

@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review October 12, 2026 13:14
@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner October 12, 2026 13:14
@alexander-alderman-webb alexander-alderman-webb changed the title chore: Deprecate view.response.render with view.render chore: Replace view.response.render with view.render Oct 12, 2026
@alexander-alderman-webb alexander-alderman-webb changed the title chore: Replace view.response.render with view.render chore: Replace deprecated view.response.render with view.render Oct 12, 2026
@alexander-alderman-webb alexander-alderman-webb changed the title chore: Replace deprecated view.response.render with view.render chore: Replace deprecated view.response.render op with view.render Oct 12, 2026
@alexander-alderman-webb
alexander-alderman-webb merged commit 888b3d3 into major/3.0 Oct 12, 2026
144 of 145 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/view.render branch October 12, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants