Repository navigation
fix(openai): finish streamed spans on iteration errors - #7966
Closed
intertermux-code wants to merge 1 commit into
Closed
intertermux-code wants to merge 1 commit into
intertermux-code wants to merge 1 commit into
Conversation
Collaborator
|
Closing this because we want to mirror the approach in the anthropic integration, which this doesn't. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenAI streamed spans were lost when an error was raised mid-iteration: the span was never finished, so the trace showed nothing.
Fix: try/finally in all 4 streaming iterators (span finished with sys.exc_info()) + patched Stream.close/AsyncStream.close to close the wrapped generator first. 16 new regression tests (4 tests x 2 span modes).
Repro: all 5 loss modes LOST before, ALL OK after. pytest tests/integrations/openai/: 713 passed. Ruff clean, mypy shows only pre-existing errors.
Fixes #7847.