Skip to content

chore: Replace deprecated db.redis op with db.query - #7967

Merged
alexander-alderman-webb merged 3 commits into
major/3.0from
webb/redis-op
Oct 13, 2026
Merged

alexander-alderman-webb merged 3 commits into
major/3.0from
webb/redis-op

Conversation

@alexander-alderman-webb

Copy link
Copy Markdown
Collaborator

Description

Contributes to #7950

See getsentry/sentry-conventions#704

Issues

Reminders

@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner October 12, 2026 14:45
@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 54893 passed | ❌ 2 failed | ⏭️ 2872 skipped | Total: 57767 | Pass Rate: 95.02% | Execution Time: 154m 52s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -80070
Passed Tests 📉 -75667
Failed Tests 📈 +1
Skipped Tests 📉 -4404

➕ New Tests (2)

View new tests
  • test_async_additional_parameters
    • File: tests.integrations.litellm.test_litellm
    • Status: ❌ Failing
  • test_cache_spans_item_size
    • File: tests.integrations.django.test_cache_module
    • Status: ❌ Failing

➖ Removed Tests (1)

View removed tests
  • test_no_integration[False-False]
    • File: tests.integrations.litellm.test_litellm

❌ Failed Tests

test_async_additional_parameters

File: tests.integrations.litellm.test_litellm
Suite: py3.10-litellm-v1.89.7
Error: pytest.PytestUnraisableExceptionWarning: Exception ignored in thread started by: <bound method Thread._bootstrap of <Thread(ThreadPoolExecutor-12_1, started 140288882345536)>> Enable tracemalloc to get traceback where the object was allocated. See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

Stack Trace
/usr/lib/python3.10/threading.py:973: in _bootstrap
    self._bootstrap_inner()
/usr/lib/python3.10/threading.py:1011: in _bootstrap_inner
    _sys.settrace(_trace_hook)
E   RuntimeError: Cannot install a trace function while another trace function is being installed

The above exception was the direct cause of the following exception:
.tox/py3.10-litellm-v1.89.7/lib/python3.10/site-packages/_pytest/runner.py:361: in from_call
    result: TResult | None = func()
.tox/py3.10-litellm-v1.89.7/lib/python3.10/site-packages/_pytest/runner.py:250: in <lambda>
    lambda: runtest_hook(item=item, **kwds),
.tox/py3.10-litellm-v1.89.7/lib/python3.10/site-packages/pluggy/_hooks.py:512: in __call__
    return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult)
.tox/py3.10-litellm-v1.89.7/lib/python3.10/site-packages/pluggy/_manager.py:120: in _hookexec
    return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
.tox/py3.10-litellm-v1.89.7/lib/python3.10/site-packages/_pytest/logging.py:865: in pytest_runtest_call
    yield
.tox/py3.10-litellm-v1.89.7/lib/python3.10/site-packages/pluggy/_callers.py:53: in run_old_style_hookwrapper
    return result.get_result()
.tox/py3.10-litellm-v1.89.7/lib/python3.10/site-packages/pluggy/_callers.py:38: in run_old_style_hookwrapper
    res = yield
.tox/py3.10-litellm-v1.89.7/lib/python3.10/site-packages/_pytest/capture.py:900: in pytest_runtest_call
    return (yield)
.tox/py3.10-litellm-v1.89.7/lib/python3.10/site-packages/_pytest/skipping.py:268: in pytest_runtest_call
    return (yield)
.tox/py3.10-litellm-v1.89.7/lib/python3.10/site-packages/_pytest/unraisableexception.py:183: in pytest_runtest_call
    collect_unraisable(item.config)
.tox/py3.10-litellm-v1.89.7/lib/python3.10/site-packages/_pytest/unraisableexception.py:79: in collect_unraisable
    raise errors[0]
.tox/py3.10-litellm-v1.89.7/lib/python3.10/site-packages/_pytest/unraisableexception.py:67: in collect_unraisable
    warnings.warn(pytest.PytestUnraisableExceptionWarning(msg))
E   pytest.PytestUnraisableExceptionWarning: Exception ignored in thread started by: <bound method Thread._bootstrap of <Thread(ThreadPoolExecutor-12_1, started 140288882345536)>>
E   Enable tracemalloc to get traceback where the object was allocated.
E   See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

test_cache_spans_item_size

File: tests.integrations.django.test_cache_module
Suite: py3.14-django-v5.2.17
Error: tests/integrations/django/test_cache_module.py:546: in test_cache_spans_item_size assert not spans[0]["attributes"]["cache.hit"] E assert not True

Stack Trace
tests/integrations/django/test_cache_module.py:546: in test_cache_spans_item_size
    assert not spans[0]["attributes"]["cache.hit"]
E   assert not True

✅ Patch coverage is 100.00%. Project has 2070 uncovered lines.
❌ Project coverage is 90.1%. Comparing base (7ed3e35) to head (870b323).

Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.28%    90.10%    -0.18%
==========================================
  Files          202       193        -9
  Lines        26639     20903     -5736
  Branches      9926      7206     -2720
==========================================
+ Hits         24050     18833     -5217
- Misses        2589      2070      -519
- Partials      1509      1232      -277

Generated by Codecov Action

@sentrivana sentrivana left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migration guide too, please, if folks have alerts/dashboards on the op's there should be a call out

@alexander-alderman-webb
alexander-alderman-webb merged commit 6450132 into major/3.0 Oct 13, 2026
9 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/redis-op branch October 13, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants