feat(boto3): Gate user identifying resource id behind `user_info` by pabloDeputter · Pull Request #7970 · getsentry/sentry-python

pabloDeputter · 2026-10-12T16:24:13Z

Description

Currently SNS extension sets cloud.resource_id/ cloud.account_id from EndpointArn, PlatformApplicationArn, SubscriptionArn, TargetArn or TopicArn; but some of these can expose PII:

EndpointArn/TargetArn (…:endpoint/GCM/myapp/<id>) point to a device's push token (https://docs.aws.amazon.com/sns/latest/dg/mobile-platform-endpoint.html + https://docs.aws.amazon.com/sns/latest/api/API_Publish.html)
SubscriptionArn (…:orders:<id>) points to one subscriber, e.g. email or phone number (https://docs.aws.amazon.com/sns/latest/api/API_Subscribe.html)

Issues

Resolves #7969

github-actions · 2026-10-12T16:45:36Z

Codecov Results 📊

📊 Comparison with Base Branch

Metric	Change
Total Tests	📉 -79744
Passed Tests	📉 -75340
Failed Tests	📈 +4
Skipped Tests	📉 -4408

➕ New Tests (5)

View new tests

test_cache_spans_decorator
- File: tests.integrations.django.test_cache_module
- Status: ❌ Failing
test_user_identity_error_event_data_collection[data_collection_user_info_true-application0]
- File: tests.integrations.django.asgi.test_asgi
- Status: ❌ Failing
test_user_identity_error_event_data_collection[data_collection_user_info_true-application1]
- File: tests.integrations.django.asgi.test_asgi
- Status: ❌ Failing
test_user_identity_error_event_data_collection[data_collection_user_info_false-application0]
- File: tests.integrations.django.asgi.test_asgi
- Status: ❌ Failing
test_user_identity_error_event_data_collection[data_collection_user_info_false-application1]
- File: tests.integrations.django.asgi.test_asgi
- Status: ❌ Failing

➖ Removed Tests (1)

View removed tests

test_no_integration[False-False]
- File: tests.integrations.litellm.test_litellm

❌ Failed Tests

`test_cache_spans_decorator`

File: tests.integrations.django.test_cache_module
Suite: py3.14-django-v5.2.17
Error: tests/integrations/django/test_cache_module.py:307: in test_cache_spans_decorator assert not spans[0]["attributes"]["cache.hit"] E assert not True

Stack Trace

tests/integrations/django/test_cache_module.py:307: in test_cache_spans_decorator
    assert not spans[0]["attributes"]["cache.hit"]
E   assert not True

`test_user_identity_error_event_data_collection[data_collection_user_info_true-application0]`

File: tests.integrations.django.asgi.test_asgi
Suite: py3.7-django-v3.2.25
Error: .tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/asgiref/testing.py:74: in receive_output return await self.output_queue.get() /usr/local/lib/python3.7/asyncio/queues.py:159: in get await getter E concurrent.futures._base.CancelledError During handling of the above exception, another exception occurred: tests/integrations/django/asgi/test_asgi.py:896: in test_user_identity_error_event_data_collection await comm.get_response() .tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/channels/testing/http.py:42: in get_response response_start = await self.receive_output(timeout) .tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/asgiref/testing.py:85: in receive_output raise e .tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/asgiref/testing.py:74: in receive_output return await self.output_queue.get() .tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/asgiref/timeout.py:71: in aexit self._do_exit(exc_type) .tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/asgiref/timeout.py:108: in _do_exit raise asyncio.TimeoutError E concurrent.futures._base.TimeoutError

Stack Trace

.tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/asgiref/testing.py:74: in receive_output
    return await self.output_queue.get()
/usr/local/lib/python3.7/asyncio/queues.py:159: in get
    await getter
E   concurrent.futures._base.CancelledError

During handling of the above exception, another exception occurred:
tests/integrations/django/asgi/test_asgi.py:896: in test_user_identity_error_event_data_collection
    await comm.get_response()
.tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/channels/testing/http.py:42: in get_response
    response_start = await self.receive_output(timeout)
.tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/asgiref/testing.py:85: in receive_output
    raise e
.tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/asgiref/testing.py:74: in receive_output
    return await self.output_queue.get()
.tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/asgiref/timeout.py:71: in __aexit__
    self._do_exit(exc_type)
.tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/asgiref/timeout.py:108: in _do_exit
    raise asyncio.TimeoutError
E   concurrent.futures._base.TimeoutError

`test_user_identity_error_event_data_collection[data_collection_user_info_true-application1]`

File: tests.integrations.django.asgi.test_asgi
Suite: py3.7-django-v3.2.25
Error: .tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/asgiref/testing.py:74: in receive_output return await self.output_queue.get() /usr/local/lib/python3.7/asyncio/queues.py:159: in get await getter E concurrent.futures._base.CancelledError During handling of the above exception, another exception occurred: tests/integrations/django/asgi/test_asgi.py:896: in test_user_identity_error_event_data_collection await comm.get_response() .tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/channels/testing/http.py:42: in get_response response_start = await self.receive_output(timeout) .tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/asgiref/testing.py:85: in receive_output raise e .tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/asgiref/testing.py:74: in receive_output return await self.output_queue.get() .tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/asgiref/timeout.py:71: in aexit self._do_exit(exc_type) .tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/asgiref/timeout.py:108: in _do_exit raise asyncio.TimeoutError E concurrent.futures._base.TimeoutError

Stack Trace

.tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/asgiref/testing.py:74: in receive_output
    return await self.output_queue.get()
/usr/local/lib/python3.7/asyncio/queues.py:159: in get
    await getter
E   concurrent.futures._base.CancelledError

During handling of the above exception, another exception occurred:
tests/integrations/django/asgi/test_asgi.py:896: in test_user_identity_error_event_data_collection
    await comm.get_response()
.tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/channels/testing/http.py:42: in get_response
    response_start = await self.receive_output(timeout)
.tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/asgiref/testing.py:85: in receive_output
    raise e
.tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/asgiref/testing.py:74: in receive_output
    return await self.output_queue.get()
.tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/asgiref/timeout.py:71: in __aexit__
    self._do_exit(exc_type)
.tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/asgiref/timeout.py:108: in _do_exit
    raise asyncio.TimeoutError
E   concurrent.futures._base.TimeoutError

`test_user_identity_error_event_data_collection[data_collection_user_info_false-application0]`

File: tests.integrations.django.asgi.test_asgi
Suite: py3.7-django-v3.2.25
Error: .tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/asgiref/testing.py:74: in receive_output return await self.output_queue.get() /usr/local/lib/python3.7/asyncio/queues.py:159: in get await getter E concurrent.futures._base.CancelledError During handling of the above exception, another exception occurred: tests/integrations/django/asgi/test_asgi.py:896: in test_user_identity_error_event_data_collection await comm.get_response() .tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/channels/testing/http.py:42: in get_response response_start = await self.receive_output(timeout) .tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/asgiref/testing.py:85: in receive_output raise e .tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/asgiref/testing.py:74: in receive_output return await self.output_queue.get() .tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/asgiref/timeout.py:71: in aexit self._do_exit(exc_type) .tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/asgiref/timeout.py:108: in _do_exit raise asyncio.TimeoutError E concurrent.futures._base.TimeoutError

Stack Trace

.tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/asgiref/testing.py:74: in receive_output
    return await self.output_queue.get()
/usr/local/lib/python3.7/asyncio/queues.py:159: in get
    await getter
E   concurrent.futures._base.CancelledError

During handling of the above exception, another exception occurred:
tests/integrations/django/asgi/test_asgi.py:896: in test_user_identity_error_event_data_collection
    await comm.get_response()
.tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/channels/testing/http.py:42: in get_response
    response_start = await self.receive_output(timeout)
.tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/asgiref/testing.py:85: in receive_output
    raise e
.tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/asgiref/testing.py:74: in receive_output
    return await self.output_queue.get()
.tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/asgiref/timeout.py:71: in __aexit__
    self._do_exit(exc_type)
.tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/asgiref/timeout.py:108: in _do_exit
    raise asyncio.TimeoutError
E   concurrent.futures._base.TimeoutError

`test_user_identity_error_event_data_collection[data_collection_user_info_false-application1]`

File: tests.integrations.django.asgi.test_asgi
Suite: py3.7-django-v3.2.25
Error: .tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/asgiref/testing.py:74: in receive_output return await self.output_queue.get() /usr/local/lib/python3.7/asyncio/queues.py:159: in get await getter E concurrent.futures._base.CancelledError During handling of the above exception, another exception occurred: tests/integrations/django/asgi/test_asgi.py:896: in test_user_identity_error_event_data_collection await comm.get_response() .tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/channels/testing/http.py:42: in get_response response_start = await self.receive_output(timeout) .tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/asgiref/testing.py:85: in receive_output raise e .tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/asgiref/testing.py:74: in receive_output return await self.output_queue.get() .tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/asgiref/timeout.py:71: in aexit self._do_exit(exc_type) .tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/asgiref/timeout.py:108: in _do_exit raise asyncio.TimeoutError E concurrent.futures._base.TimeoutError

Stack Trace

.tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/asgiref/testing.py:74: in receive_output
    return await self.output_queue.get()
/usr/local/lib/python3.7/asyncio/queues.py:159: in get
    await getter
E   concurrent.futures._base.CancelledError

During handling of the above exception, another exception occurred:
tests/integrations/django/asgi/test_asgi.py:896: in test_user_identity_error_event_data_collection
    await comm.get_response()
.tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/channels/testing/http.py:42: in get_response
    response_start = await self.receive_output(timeout)
.tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/asgiref/testing.py:85: in receive_output
    raise e
.tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/asgiref/testing.py:74: in receive_output
    return await self.output_queue.get()
.tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/asgiref/timeout.py:71: in __aexit__
    self._do_exit(exc_type)
.tox/py3.7-django-v3.2.25/lib/python3.7/site-packages/asgiref/timeout.py:108: in _do_exit
    raise asyncio.TimeoutError
E   concurrent.futures._base.TimeoutError

✅ Patch coverage is 100.00%. Project has 2064 uncovered lines.
❌ Project coverage is 90.13%. Comparing base (888b3d3) to head (99de60f).

Coverage diff

@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.28%    90.13%    -0.15%
==========================================
  Files          202       193        -9
  Lines        26639     20910     -5729
  Branches      9926      7210     -2716
==========================================
+ Hits         24050     18846     -5204
- Misses        2589      2064      -525
- Partials      1509      1233      -276

Generated by Codecov Action

feat(boto3): Gate user identifying resource id behind user_info

99de60f

Navigation Menu

Repository navigation

feat(boto3): Gate user identifying resource id behind `user_info` - #7970

feat(boto3): Gate user identifying resource id behind `user_info`#7970
pabloDeputter wants to merge 1 commit into
major/3.0from
pablo/gate-sns-arns

pabloDeputter commented Oct 12, 2026

Uh oh!

github-actions Bot commented Oct 12, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

pabloDeputter commented Oct 12, 2026

Description

Issues

Uh oh!

github-actions Bot commented Oct 12, 2026

Codecov Results 📊

📊 Comparison with Base Branch

➕ New Tests (5)

➖ Removed Tests (1)

❌ Failed Tests

test_cache_spans_decorator

test_user_identity_error_event_data_collection[data_collection_user_info_true-application0]

test_user_identity_error_event_data_collection[data_collection_user_info_true-application1]

test_user_identity_error_event_data_collection[data_collection_user_info_false-application0]

test_user_identity_error_event_data_collection[data_collection_user_info_false-application1]

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

`test_cache_spans_decorator`

`test_user_identity_error_event_data_collection[data_collection_user_info_true-application0]`

`test_user_identity_error_event_data_collection[data_collection_user_info_true-application1]`

`test_user_identity_error_event_data_collection[data_collection_user_info_false-application0]`

`test_user_identity_error_event_data_collection[data_collection_user_info_false-application1]`