Repository navigation
fix(client-reports): Emit callback_error when a processor raises - #8005
Conversation
Codecov Results 📊✅ 55725 passed | ⏭️ 2872 skipped | Total: 58597 | Pass Rate: 95.1% | Execution Time: 152m 25s 📊 Comparison with Base Branch
➖ Removed Tests (1)View removed tests
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2070 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## master #PR +/-##
==========================================
- Coverage 90.28% 90.10% -0.18%
==========================================
Files 202 193 -9
Lines 26639 20917 -5722
Branches 9926 7208 -2718
==========================================
+ Hits 24050 18847 -5203
- Misses 2589 2070 -519
- Partials 1509 1233 -276Generated by Codecov Action |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 35cede5. Configure here.
| except Exception: | ||
| exception_raised = True | ||
| raise |
There was a problem hiding this comment.
You could also directly log the exception here (like capture_internal_exceptions() would).
I think this is also worse in some ways though, so up to you.
| except Exception: | |
| exception_raised = True | |
| raise | |
| except Exception as exc: | |
| exception_raised = True | |
| logger.error("Internal error in sentry_sdk", exc_info=sys.exc_info()) |
There was a problem hiding this comment.
I think the simple log we added is sufficient for now. If we have requests for more info, we can add this.

We're not recording the correct reason if a event/error processor raises (should be
callback_error).Closes https://linear.app/getsentry/issue/PY-2888/drop-events-if-a-processor-raises