Repository navigation
fix(huggingface_hub): Stop swallowing exceptions during stream iteration - #8018
Merged
alexander-alderman-webb merged 1 commit intoOct 13, 2026
Conversation
Split out of getsentry#7946 per review. Mid-stream provider exceptions raised by the text-generation and chat-completion iterators were swallowed by the outer capture_internal_exceptions(); they now bubble out to the caller while the span is still closed out.
Collaborator
|
I'll close this until we agree on an approach in #8017 |
alexander-alderman-webb
changed the title
alexander-alderman-webb
enabled auto-merge (squash)
October 13, 2026 11:52
alexander-alderman-webb
approved these changes
Oct 13, 2026
alexander-alderman-webb
merged commit Oct 13, 2026
7e8594c
into
getsentry:master
310 of 318 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7889.
Split out of #7946 per review — this one covers the huggingface_hub integration only. Mid-stream provider exceptions raised by the text-generation and chat-completion iterators were swallowed by the outer
capture_internal_exceptions(); they now bubble out to the caller while the span is still closed out.