Repository navigation
Conversation
After the handler returns, both paths now use a helper that treats isError as true on either a dict or a result object. When that check matches, the span data error.type is set to tool_error, and this path does not write a new span status. Fixes getsentry#7890. Refs getsentry#7890
Collaborator
|
We still haven't agreed on an approach in the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After the handler returns, both paths now use a helper that treats isError as true on either a dict or a result object. When that check matches, the span data error.type is set to tool_error, and this path does not write a new span status. Refs #7890.
An MCP tools/call that comes back with isError true is still delivered to the client, but the span Sentry stores for that call has no error.type. Those tool failures therefore do not show up in the Python server's tool error rate. The mcp 1.x handler wrapper and the mcp 2.x tool-call middleware only record a failure when the handler raises and that exception is caught. A normal return of a CallToolResult, or of a dict whose isError field is true, skips that path, so the span is finished without error.type.
Issues
Refs #7890
Reminders
Not applicable to this change.
AI was used for assistance.