Skip to content

chore(deps): update dependency java-jdk to v25 - #8021

Closed
renovate[bot] wants to merge 1 commit into
masterfrom
renovate/github-workflows
Closed

renovate[bot] wants to merge 1 commit into
masterfrom
renovate/github-workflows

Conversation

@renovate

@renovate renovate Bot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Type Update Change
java-jdk uses-with major 21 → 25

Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate
renovate Bot requested a review from a team as a code owner October 13, 2026 13:16
@sentrivana

Copy link
Copy Markdown
Collaborator

We can't do this, it breaks older spark versions.

@sentrivana sentrivana closed this Oct 13, 2026
with:
distribution: 'temurin'
java-version: '21'
java-version: '25'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JDK bump edits generated workflow, leaves template at 21

Update java-version in scripts/split_tox_gh_actions/templates/test_group.jinja and regenerate; this file is auto-generated and the next split run will revert 25 back to 21.

Evidence
  • File header states this YAML is generated by scripts/split_tox_gh_actions/split_tox_gh_actions.py and must not be edited by hand.
  • Source template scripts/split_tox_gh_actions/templates/test_group.jinja still hardcodes java-version: '21' under {% if needs_java %}.
  • needs_java is set when the group includes spark (FRAMEWORKS_NEEDING_JAVA), so regeneration rewrites this workflow from the template.

Identified by Warden · code-review · F77-BY4

with:
distribution: 'temurin'
java-version: '21'
java-version: '25'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spark integration tests now run on JDK 25 without a compatibility pin

This changes the JVM used by Spark integration tests to Temurin 25. The current PySpark 3.5.9 and 4.2.0 tox factors do not match the existing Java 11 override, so their local SparkContext startup will use JDK 25. Please validate these combinations before merging or pin the Spark tests to a supported JDK.

Evidence
  • The workflow installs Temurin 25 before running the Spark tox environments.
  • tox.ini defines Spark factors for PySpark 3.5.9 and 4.2.0; its Java 11 override names only Spark 3.0.3 and 3.5.6.
  • The Spark tests create a local SparkContext, which starts the JVM selected by the environment.

Identified by Warden · code-review · TQ6-CST

@renovate

renovate Bot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor Author

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 25.x releases. But if you manually upgrade to 25.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate
renovate Bot deleted the renovate/github-workflows branch October 13, 2026 13:19

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a1f5fd5. Configure here.

with:
distribution: 'temurin'
java-version: '21'
java-version: '25'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java 25 unsupported by Spark 3.5

Medium Severity

This JDK is installed for Spark tests, and pyspark 3.5.9 has no JAVA_HOME override. Spark 3.5 supports only Java 8/11/17; Java 25 support arrived in Spark 4.2.0. Those envs will start a real SparkContext on Java 25, which can fail the Tasks job.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit a1f5fd5. Configure here.

with:
distribution: 'temurin'
java-version: '21'
java-version: '25'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated workflow diverges from template

Low Severity

This file is generated from test_group.jinja, which still sets java-version to 21. Updating only the generated workflow leaves the source of truth unchanged, so the next split_tox_gh_actions.py or weekly toxgen run will revert the bump.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit a1f5fd5. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

Coverage Results 📊

✅ 133643 passed | ❌ 10 failed | ⏭️ 7276 skipped | Total: 140929 | Pass Rate: 94.83% | Execution Time: 435m 9s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -13
Passed Tests 📉 -22
Failed Tests 📈 +9
Skipped Tests —

➕ New Tests (1)

View new tests
  • test_errors_in_ray_actors[False]
    • File: tests.integrations.ray.test_ray
    • Status: ❌ Failing

➖ Removed Tests (1)

View removed tests
  • test_segment_uses_downsampled_rate
    • File: tests.test_monitor

❌ Failed Tests

test_errors_in_ray_actors[False]

File: tests.integrations.ray.test_ray
Suite: py3.9-ray-v2.7.2
Error: ValueError: Ray component metrics_export is trying to use a port number 52365 that is used by other components. Port information: {'gcs': 'random', 'object_manager': 'random', 'node_manager': 'random', 'gcs_server': 36658, 'client_server': 'random', 'dashboard': 'random', 'dashboard_agent_grpc': 63021, 'dashboard_agent_http': 52365, 'dashboard_grpc': 'random', 'runtime_env_agent': 54170, 'metrics_export': 52365, 'redis_shards': 'random', 'worker_ports': 'random'} If you allocate ports, please make sure the same port is not used by multiple components.

Stack Trace
tests/integrations/ray/test_ray.py:499: in test_errors_in_ray_actors
    ray.init(
.tox/py3.9-ray-v2.7.2/lib/python3.9/site-packages/ray/_private/client_mode_hook.py:103: in wrapper
    return func(*args, **kwargs)
.tox/py3.9-ray-v2.7.2/lib/python3.9/site-packages/ray/_private/worker.py:1536: in init
    _global_node = ray._private.node.Node(
.tox/py3.9-ray-v2.7.2/lib/python3.9/site-packages/ray/_private/node.py:303: in __init__
    self._ray_params.update_pre_selected_port()
.tox/py3.9-ray-v2.7.2/lib/python3.9/site-packages/ray/_private/parameter.py:348: in update_pre_selected_port
    raise ValueError(
E   ValueError: Ray component metrics_export is trying to use a port number 52365 that is used by other components.
E   Port information: {'gcs': 'random', 'object_manager': 'random', 'node_manager': 'random', 'gcs_server': 36658, 'client_server': 'random', 'dashboard': 'random', 'dashboard_agent_grpc': 63021, 'dashboard_agent_http': 52365, 'dashboard_grpc': 'random', 'runtime_env_agent': 54170, 'metrics_export': 52365, 'redis_shards': 'random', 'worker_ports': 'random'}
E   If you allocate ports, please make sure the same port is not used by multiple components.

✅ Patch coverage is 100.00% (no changed executable lines found; target 80%).
Project statement coverage is 90.26% (up 0.02 percentage points from base (2ffd383) to head (a1f5fd5)).

Coverage diff
@@            Coverage Diff             @@
##        master     #8021       +/-##
==========================================
+ Coverage    90.24%    90.26%    +0.02%
==========================================
  Files          202       202         —
  Tracked lines     26659     26660        +1
  Branches      9926      9926         —
==========================================
+ Hits         24055     24062        +7
+ Misses        2604      2598        -6
+ Partials      1510      1509        -1

Generated by Coverage Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant