ref(autofix): Cleanup AutofixStep and autofix-in-seer logic - #123865
Conversation
github-actions
Bot
added
the
Scope: Backend
There was a problem hiding this comment.
nit: do we even need the rca folder?
There was a problem hiding this comment.
Plan was to separate by steps to start - stacked PR on this (#123866) might illustrate it better.
The feature impl can be moved out of rca, but at least specific triggering for RCA/solution/code I'd prefer to split to start.
I think once we're all in seer there's going to be a lot of cleanup we can do so I think at that time we can really make things better organized.
| return json.dumps(base_shas) | ||
|
|
||
|
|
||
| def trigger_autofix_rca_in_seer( |
There was a problem hiding this comment.
nit: the layering with trigger_autofix_rca_feature feels kind of odd and i'm not a huge fan of the trigger_autofix_rca_in_seer name
There was a problem hiding this comment.
I tend to agree but this was just mostly leveraging the existing pattern. I think I'll keep for the time being here, but we can do a bigger cleanup once we're largerly in seer
1875804 to
fe02724
Compare
2 participants
Minor organizational cleanup in anticipation for upcoming seer autofix steps beyond RCA. Moves AutofixStep into its own file and separates new autofix step firing into separate functions to clean up the trigger_autofix_agent code.
Stack created with GitHub Stacks CLI • Give Feedback 💬