fix: handle pointers when serializing context#2219
Merged
Conversation
Signed-off-by: Thomas Lercher <thomas.lercher@exaring.de>
tlercher
force-pushed
the
fix/aws_context
branch
from
d05e561 to
467fddd
Compare
felixfontein
approved these changes
Jun 16, 2026
felixfontein
left a comment
felixfontein
left a comment
Contributor
There was a problem hiding this comment.
Thanks for reporting and fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting with the change #2120 we've run into the issue that when saving a SOPS files the context values of a provider (in our case AWS KMS using
tenant) gets mangled and a pointer value gets written into the encrypted file.If such a invalid file is committed it cannot be decrypted anymore by
sopssince it lacks the propercontextto do so.i also took the liberty to add a method body to
TestSerializeMetadataeven if it just tests the AWS KMS case i've run into for now. -> Should this be a more specific test?