Skip to content

Allow for more clock drift when generating the JWT #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dscho wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −3
Open

Allow for more clock drift when generating the JWT #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ed40ee
Allow for more clock drift when generating the JWT
dscho Jun 29, 2026
90c8a25
trigger-workflow-dispatch: fix stale test mock
dscho Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions GitGitGadget/github-api-request-as-app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ const gitHubAPIRequestAsApp = async (context, requestMethod, requestPath, body)
const payload = {
// issued at time, 60 seconds in the past to allow for clock drift
iat: now - 60,
// JWT expiration time (10 minute maximum)
exp: now + (10 * 60),
// JWT expiration time (10 minute maximum, use 9 to allow for clock drift)
exp: now + (9 * 60),
// GitHub App's identifier
iss: process.env['GITHUB_APP_ID']
}
Expand Down
2 changes: 1 addition & 1 deletion __tests__/trigger-workflow-dispatch.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const mockHTTPSRequest = jest.fn(async (_context, _hostname, method, requestPath
}
}
if (method === 'GET' && requestPath === '/user') return { login: 'the actor' }
if (method === 'GET' && requestPath === '/repos/hello/world/actions/runs?actor=the actor&event=workflow_dispatch&created>=2023-01-23T01:23:45.000Z') {
if (method === 'GET' && requestPath === '/repos/hello/world/actions/runs?actor=the actor&event=workflow_dispatch&created=2023-01-23T01:23:45.000Z..*') {
return {
workflow_runs: [
{ path: 'not this one.yml' },
Expand Down
Loading