net by daniel-noland · Pull Request #1752 · githedgehog/dataplane

daniel-noland · 2026-08-26T02:58:36Z

No description provided.

coderabbitai · 2026-08-26T02:58:43Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: be14c6b0-2763-4724-abb0-680b672a89e7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

_{Comment @coderabbitai help to get the list of available commands.}

codecov · 2026-08-26T17:49:01Z

Codecov Report

❌ Patch coverage is 97.19828% with 26 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
net/src/headers/view.rs	94.21%	4 Missing and 3 partials ⚠️
net/src/headers/embedded.rs	95.65%	5 Missing and 1 partial ⚠️
net/src/headers/embedded_view.rs	96.53%	4 Missing and 2 partials ⚠️
net/src/headers/within.rs	93.22%	3 Missing and 1 partial ⚠️
net/src/headers/mod.rs	98.75%	1 Missing and 1 partial ⚠️
net/src/headers/pat.rs	99.63%	0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

mvachhar

I think we need one extra test regarding checksums. Might as well fix the wierd licensing verbiage while you're at it.

mvachhar · 2026-08-27T20:08:11Z

+
+        /// Eight words to fold, over a UDP pseudo-header.
+        #[test]
+        fn a_v6_address_change_matches_a_fresh_udp_checksum() {


We need a test for the incremental checksum update where the quoted packet header is truncated below the required 128 bytes. We won't ever generate such a packet but we can receive one. What happens in that case when we try to update the checksum?

Nothing happens tho. The truncated quote ships exactly as received.

I can write a test to assert that if you like

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Daniel Noland <daniel@githedgehog.com>

Extra checks to make sure the unsafe version is sound. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Daniel Noland <daniel@githedgehog.com>

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Daniel Noland <daniel@githedgehog.com>

- Derive each shape from its match chain. - Compare returned layer addresses across all argument counts. - Add VXLAN rejection cases. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Daniel Noland <daniel@githedgehog.com>

Scramble parent protocol fields, then deparse and reparse to verify that `Within::conform` behaves correctly. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Daniel Noland <daniel@githedgehog.com>

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Daniel Noland <daniel@githedgehog.com>

Lowered the count for miri. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Daniel Noland <daniel@githedgehog.com>

daniel-noland force-pushed the pr/daniel-noland/spec-tooling branch from 0ea0d48 to 5b72388 Compare August 26, 2026 17:30

daniel-noland force-pushed the pr/daniel-noland/fuzz-net-headers branch from f5188c3 to 75fbc59 Compare August 26, 2026 17:30

daniel-noland force-pushed the pr/daniel-noland/fuzz-net-headers branch from 75fbc59 to 8086c9c Compare August 26, 2026 19:36

daniel-noland force-pushed the pr/daniel-noland/spec-tooling branch 2 times, most recently from 671b989 to b687ddd Compare August 26, 2026 20:41

daniel-noland force-pushed the pr/daniel-noland/fuzz-net-headers branch 2 times, most recently from dd9b98e to 83d440b Compare August 26, 2026 21:02

daniel-noland force-pushed the pr/daniel-noland/spec-tooling branch from 069153b to d80fe2d Compare August 26, 2026 21:13

daniel-noland force-pushed the pr/daniel-noland/fuzz-net-headers branch from 83d440b to bbcc339 Compare August 26, 2026 21:13

daniel-noland force-pushed the pr/daniel-noland/spec-tooling branch 3 times, most recently from 3d5b3de to a2e4e51 Compare August 27, 2026 01:25

daniel-noland force-pushed the pr/daniel-noland/fuzz-net-headers branch from bbcc339 to 73933c6 Compare August 27, 2026 01:29

daniel-noland force-pushed the pr/daniel-noland/spec-tooling branch from a2e4e51 to 046ea6b Compare August 27, 2026 01:41

daniel-noland force-pushed the pr/daniel-noland/fuzz-net-headers branch from 73933c6 to 493afc8 Compare August 27, 2026 01:41

daniel-noland commented Aug 27, 2026

View reviewed changes

Comment thread net/src/headers/embedded_view.rs Outdated

daniel-noland force-pushed the pr/daniel-noland/fuzz-net-headers branch 3 times, most recently from 8bd7e1c to e7119dc Compare August 27, 2026 03:26

daniel-noland marked this pull request as ready for review August 27, 2026 03:29

daniel-noland requested a review from a team as a code owner August 27, 2026 03:29

daniel-noland requested review from sergeymatov and a lite review from Copilot and removed request for a team August 27, 2026 03:29

Copilot AI reviewed Aug 27, 2026

daniel-noland requested a review from mvachhar August 27, 2026 03:29

daniel-noland self-assigned this Aug 27, 2026

daniel-noland changed the title ~~test(net): property-test the checksum, headers view, matcher, and builder~~ test(net): property-test the rest of net Aug 27, 2026

daniel-noland added the clean-up Code base clean-up, no functional change label Aug 27, 2026

mvachhar requested changes Aug 27, 2026

View reviewed changes

daniel-noland changed the title ~~test(net): property-test the rest of net~~ net Aug 28, 2026

daniel-noland force-pushed the pr/daniel-noland/fuzz-net-headers branch 2 times, most recently from 98d9cda to b760312 Compare August 28, 2026 05:11

daniel-noland force-pushed the pr/daniel-noland/spec-tooling branch from 9b64d3b to 24551ab Compare August 28, 2026 05:11

daniel-noland force-pushed the pr/daniel-noland/fuzz-net-headers branch from dd860c4 to 8bf6ba3 Compare August 28, 2026 06:39

daniel-noland force-pushed the pr/daniel-noland/spec-tooling branch from 24551ab to 3230698 Compare August 28, 2026 09:14

daniel-noland force-pushed the pr/daniel-noland/fuzz-net-headers branch 2 times, most recently from 4262cba to cfaa23b Compare August 28, 2026 17:15

daniel-noland and others added 10 commits August 28, 2026 11:30

fix(net): actually store incremental checksum updates

b464b66

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Daniel Noland <daniel@githedgehog.com>

test(net): check HeadersView against the safe matcher

f8cb8f5

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Daniel Noland <daniel@githedgehog.com>

test(net): check the mutable HeadersView boundary

0b7e3f7

Extra checks to make sure the unsafe version is sound. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Daniel Noland <daniel@githedgehog.com>

test(net): check HeadersView for higher arg count

f9aa213

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Daniel Noland <daniel@githedgehog.com>

test(net): embedded views and extensions

8b35924

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Daniel Noland <daniel@githedgehog.com>

test(net): optional matchers are never stricter than required

9b20553

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Daniel Noland <daniel@githedgehog.com>

test(net): check builder conformance

c03e56f

Scramble parent protocol fields, then deparse and reparse to verify that `Within::conform` behaves correctly. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Daniel Noland <daniel@githedgehog.com>

test(net): ICMP subtype and quoted-ICMP builders

3f3590b

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Daniel Noland <daniel@githedgehog.com>

test(net): keep embedded checks active under coverage

18802fb

Lowered the count for miri. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Daniel Noland <daniel@githedgehog.com>

daniel-noland force-pushed the pr/daniel-noland/fuzz-net-headers branch from cfaa23b to 18802fb Compare August 28, 2026 17:33

daniel-noland requested a review from mvachhar August 28, 2026 17:39

Navigation Menu

Uh oh!

net - #1752

net#1752
daniel-noland wants to merge 10 commits into
pr/daniel-noland/spec-toolingfrom
pr/daniel-noland/fuzz-net-headers

daniel-noland commented Aug 26, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Aug 26, 2026 •

edited

Loading

Review skipped

Uh oh!

codecov Bot commented Aug 26, 2026 •

edited

Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

mvachhar left a comment

Uh oh!

mvachhar Aug 27, 2026

Uh oh!

daniel-noland Aug 28, 2026

Uh oh!

daniel-noland Aug 28, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

daniel-noland commented Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

codecov Bot commented Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

mvachhar left a comment

Choose a reason for hiding this comment

Uh oh!

mvachhar Aug 27, 2026

Choose a reason for hiding this comment

Uh oh!

daniel-noland Aug 28, 2026

Choose a reason for hiding this comment

Uh oh!

daniel-noland Aug 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

daniel-noland commented Aug 26, 2026 •

edited

Loading

coderabbitai Bot commented Aug 26, 2026 •

edited

Loading

codecov Bot commented Aug 26, 2026 •

edited

Loading