-
Notifications
You must be signed in to change notification settings - Fork 2.1k
C#: Support replaces-base via the DependabotProxy.
#22494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
michaelnebel
wants to merge
9
commits into
github:main
Choose a base branch
from
michaelnebel:csharp/replaces-base
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
927aab4
C#: DependabotProxy now parses replaces-base and exposes a list of UR…
michaelnebel 000026a
C#: Use the RegistryUrls from the dependabot proxy as default feeds i…
michaelnebel 76289fa
C#: Add change-note.
michaelnebel 20241f7
C#: Preserve semantics of reachability for default feeds when using […
michaelnebel ffdd4f6
C#: Remove isNullOrEmpty check as it is implied by the case above.
michaelnebel 80b8f84
C#: Make a complete replacement of the default nuget.org feed in case…
michaelnebel abecbeb
C#: Exclude TryRestoreManually fallback without nugetSources when pri…
michaelnebel c6d573d
C#: Minor improvements to unit test.
michaelnebel 2f69127
C#: Address review comments.
michaelnebel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's possible to set the environment variable for the fallback feeds in Default Setup, but I would still treat both those and the ones from the private registry configurations as explicit, user-provided configuration. Therefore, it might make sense to compute
fallbackFeeds.UnionWith(defaultFeeds);even if there are fallback feeds configured in the environment variable. Alternatively, it might be good to at least visibly log that we are ignoring anything that doesn't come from the environment variable, when it is configured.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the setting fallback nuget feeds using the environment variable was introduced as an override mechanism to force the use of the a specific set of feeds (if they are considered reachable) - I don't think we should do substitutions or additions in this case (or at least not as a part of this PR).