fix: restore the prototype and establish regression coverage - #1
Open
ApexAiOfficial wants to merge 8 commits into
Open
fix: restore the prototype and establish regression coverage#1ApexAiOfficial wants to merge 8 commits into
ApexAiOfficial wants to merge 8 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR restores the Git SMS proof of concept to a working, testable baseline without expanding it into production deployment or GitHub Actions control.
The current application fails during import because
natural_language_router.pyimportscreate_repoandcreate_issuefromcommands.py, where those functions are not defined. The implementation also contains duplicated logic, eager model initialization, inconsistent configuration, unbounded GitHub requests, and no regression coverage.Changes
Scope
This remains a read-only proof of concept.
Twilio signature verification, sender authorization,
MessageSididempotency, rate limiting, durable audit logging, GitHub App authentication, and GitHub Actions control are intentionally deferred to separate follow-up changes.Validation
A self-review of the initial implementation found two important coverage gaps: the import test did not prove behavior in a fresh process, and the natural-language write paths lacked direct regression tests. Both are now covered.
Happy to rescope or split this differently if another first step would be easier to review. I’m opening this as a concrete starting point rather than assuming this is exactly the direction maintainers prefer.