@bobek:
Hi, I've need to be able to define more extensive filters on reports and also noticed that you don't do pagination, which yield in missing records. I've hacked something quickly in https://github.com/Showmax/hackerone-client/tree/reports-find . It should be considered WIP, for example abstracting pagination out of this methods and actually making it more robust (similarly to your parse_response method).
But I thought that you may be interested in the work.
@oreoshake:
Thanks for the branch! I hadn't even thought about pagination, thankfully our queries always return a small result.
Just some bikesheding: I think we should augment the existing reports method rather than adding a new one.
@bobek:
Just some bikesheding: I think we should augment the existing reports method rather than adding a new one.
I am totally for it. I've just created a new method to separate the code at the moment, before I get some feedback from you.
@esjee:
This is really great! Would you be up for creating a pull request? Is there anything I can do to help you?
@oreoshake:
Just adding a note here that independent of pagination implementation, we should eventually add an auto-paginate feature a la octokit.
Transferred from oreoshake/hackerone-client#27
@bobek:
Hi, I've need to be able to define more extensive filters on reports and also noticed that you don't do pagination, which yield in missing records. I've hacked something quickly in https://github.com/Showmax/hackerone-client/tree/reports-find . It should be considered WIP, for example abstracting pagination out of this methods and actually making it more robust (similarly to your
parse_responsemethod).But I thought that you may be interested in the work.
@oreoshake:
Thanks for the branch! I hadn't even thought about pagination, thankfully our queries always return a small result.
Just some bikesheding: I think we should augment the existing
reportsmethod rather than adding a new one.@bobek:
I am totally for it. I've just created a new method to separate the code at the moment, before I get some feedback from you.
@esjee:
This is really great! Would you be up for creating a pull request? Is there anything I can do to help you?
@oreoshake:
Just adding a note here that independent of pagination implementation, we should eventually add an auto-paginate feature a la octokit.
Transferred from oreoshake/hackerone-client#27