build(deps-dev): bump js-yaml from 4.3.1 to 4.3.2 - #48
Merged
Merged
Conversation
Remediate GHSA-2883-xcg3-v3hh in the transitive development dependency without changing the parent range or unrelated packages.\n\nRelated: github/vuln-mgmt#250775 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
manuelpuyol
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade the transitive development dependency
js-yamlfrom 4.3.1 to 4.3.2 to remediate GHSA-2883-xcg3-v3hh, tracked by Dependabot alert 81.Affected js-yaml 4.x versions (
>=4.0.0 <4.3.2) do not count empty merge-source mappings towardmaxTotalMergeKeys, allowing repeated merges to consume excessive CPU without reaching the configured limit. Version 4.3.2 counts each merge-source mapping against that budget.Related: github/vuln-mgmt#250775 (due 2026-12-12 UTC). This issue is robot-managed and should remain open until the scanner detects resolution; this PR deliberately does not auto-close it.
The previous Dependabot upgrade, #46, moved js-yaml from 4.3.0 to 4.3.1. No open Dependabot PR covered 4.3.2 when this change was prepared.
Scope
Only
package-lock.jsonchanges: thenode_modules/js-yamlversion, resolved tarball URL, and integrity hash. Generated with:@eslint/eslintrc@3.3.6already requiresjs-yaml@^4.3.0, which accepts 4.3.2. No manifest change, override, parent upgrade, or unrelated lockfile churn is needed. The dependency remains development-only; no library source, API, runtime dependency, or UI change is included.Validation
Validated locally with Node 26.5.0 and npm 11.17.0 (CI also uses Node 26):
npm ci --no-audit --no-fundnpm testnpm run buildtsc --noEmit, plus ESM and CommonJS buildsnpm ls js-yaml --all@eslint/eslintrc@3.3.6 > js-yaml@4.3.2registry.npmjs.org; downloaded tarball SHA-512 and SHA-1 match registry metadata.npmrc'smin-release-age=3git diff --checkCheck notes: npm reported install-script approval warnings for existing
fsevents@2.3.3andunrs-resolver@1.11.1. Their scripts were left unapproved; installation and every check still passed. No script-approval policy was changed. Local npm audit was disabled and no third-party dependency scanner was used.There is no repository-local PR template or SERVICEOWNERS file/gate. No files are added, renamed, or deleted. Existing CODEOWNERS routes review to
@github/web-systems-reviewers. No workflows or ownership settings are changed.CI and review readiness
All five reported checks passed on commit
72c17e771a6e7ee081a882f477e1232757d968ff:build(Node CI),Analyze (actions),Analyze (javascript-typescript)and aggregateCodeQL(CodeQL run), andgithub-advanced-security(run). No workflow approval is pending.GitHub reports no merge conflicts. The remaining merge gate is one approving human review, required by branch protection. Review requests are present for
@manuelpuyoland@github/web-systems-reviewers.Automated review limitation: Copilot's reviewer reported that it could not review any files in this lockfile-only PR. The direct diff and dependency metadata checks above were completed; this is not a substitute for the required human approval.