Fix: CFXMLNode returns its type code and compares nodes by value - #147
Open
DTW-Thalion wants to merge 1 commit into
Open
Fix: CFXMLNode returns its type code and compares nodes by value#147DTW-Thalion wants to merge 1 commit into
DTW-Thalion wants to merge 1 commit into
Conversation
DTW-Thalion
force-pushed
the
fix-cfxmlnode-typecode-equal
branch
from
July 24, 2026 15:22
d0460b0 to
e605ab5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two corrections to CFXMLNode, each verified against Apple CoreFoundation.
CFXMLNodeGetTypeCode returned the runtime flags field, which CFXMLNodeCreate never sets, so every node reported type code 0. It now returns the stored type.
CFXMLNodeEqual fell through to returning false for the node types that carry no additional info (text, comment, CDATA section, whitespace, document fragment) and for attribute-list declarations, so a node never equalled its copy. It now returns true once the type, string and version match and any typed info compares equal.
The tests typecode.m and equal.m fail before these changes and pass after.