Skip to content

tests: add CFAttributedString accessor tests - #149

Open
DTW-Thalion wants to merge 1 commit into
gnustep:masterfrom
DTW-Thalion:tests-cfattributedstring
Open

tests: add CFAttributedString accessor tests#149
DTW-Thalion wants to merge 1 commit into
gnustep:masterfrom
DTW-Thalion:tests-cfattributedstring

Conversation

@DTW-Thalion

Copy link
Copy Markdown
Contributor

Adds accessor coverage for CFAttributedString: creating an attributed string and reading its type ID, string, length, attributes and single attribute with effective range, copying it, creating a mutable copy that keeps the string and attributes, and creating a mutable string then replacing whole and partial character ranges.

Verified against Apple CoreFoundation.

@HendrikHuebner

Copy link
Copy Markdown
Contributor

Try rebasing to include the new CI workflows please.

@DTW-Thalion
DTW-Thalion force-pushed the tests-cfattributedstring branch from f5e85e8 to c599064 Compare July 24, 2026 15:22
@DTW-Thalion

DTW-Thalion commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

Rebased onto current master so this picks up the new CI workflows.

Doing the rebase surfaced a pre-existing bug in master that breaks CI for every branch, so I've opened #155 to fix it. In short: the new fast-enumeration tests (Tests/CFDictionary/fast_enumeration.m and Tests/CFSet/fast_enumeration.m, added in #117) import <Foundation/NSNumber.h>. GNUstep declares NSNumber in Foundation/NSValue.h and ships no standalone NSNumber.h, and the macOS compatibility compile (-framework Foundation) doesn't expose one as an includable header either, so both files fail to build on both runners with:

fast_enumeration.m:2:9: fatal error: 'Foundation/NSNumber.h' file not found

A failed build makes make check exit non-zero, which fails the whole Linux and Apple jobs on every PR. #155 switches those two imports to the <Foundation/Foundation.h> umbrella, which resolves NSNumber on both platforms. Once #155 lands, the rebased PRs should go green via the merge-ref build.

cc @stefanbidi @HendrikHuebner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants