Fix: implement NSView layout-guide support - #552
Merged
Conversation
The NSView (NSLayoutGuideSupport) category was declared but had no implementation, so -addLayoutGuide:, -removeLayoutGuide: and -layoutGuides were unavailable. Track the guides on the view, set and clear each guide's owning view, and report them.
DTW-Thalion
force-pushed
the
fix/nsview-layout-guides
branch
from
July 26, 2026 11:08
deda9ce to
3dddf83
Compare
START_SET creates an autorelease pool and END_SET releases it, so the pool these tests create around the set is redundant.
fredkiefer
approved these changes
Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
NSView (NSLayoutGuideSupport)category (addLayoutGuide:,removeLayoutGuide:,layoutGuides) was declared in NSLayoutGuide.h but never implemented, so a view could not host layout guides.This tracks the guides on the view, sets each guide's owning view on add and clears it on remove, ignores duplicate adds, and returns an empty array (not nil) when there are none.
Verified against AppKit on macOS: after
addLayoutGuide:the guide'sowningViewis the view andlayoutGuidescontains it; afterremoveLayoutGuide:both are reversed. Includes a test. Existing NSView tests still pass.