Repository navigation
fix(output): keep key columns visible on narrow terminals - #311
Open
jpage-godaddy wants to merge 1 commit into
Open
jpage-godaddy wants to merge 1 commit into
jpage-godaddy wants to merge 1 commit into
Conversation
Upgrade to cli-engine 0.10.0 and mark the columns a table is unreadable without as essential, so they are never hidden or truncated when the terminal is narrow or output is piped at the default 80-column width. Lower-priority columns (descriptions, record IDs, secondary prices) are hidden first instead. `dns list` now renders through a declared view so its type, name, and data columns are protected too. Co-Authored-By: Claude Code <noreply@anthropic.com>
jpage-godaddy
requested review from
axburgess-godaddy,
jpearlman-godaddy,
mguerrero3-godaddy,
qcai-godaddy,
rts1-godaddy,
sgopalan-godaddy,
smukherjee-godaddy and
wcole1-godaddy
as code owners
October 5, 2026 16:57
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Several agreement and API columns promised as essential remain eligible for hiding on narrow displays.
Review effort: Balanced
Findings: 7
Open (7)
What changed in this PR
Updates table rendering so critical columns remain visible on narrow terminals.
Changes:
- Upgrades
cli-engineto 0.10.0. - Marks key DNS, domain, platform, and API columns as essential.
- Adds a declared DNS list view and narrow-width regression tests.
| File | Description |
|---|---|
rust/Cargo.toml |
Upgrades cli-engine. |
rust/Cargo.lock |
Locks the upgraded dependency. |
rust/src/dns/list.rs |
Adds an essential-column view and test. |
rust/src/dns/add.rs |
Protects add-result columns. |
rust/src/dns/delete.rs |
Protects delete-result columns. |
rust/src/dns/set/mod.rs |
Protects set-plan columns. |
rust/src/dns/set/outcome.rs |
Uses the preview rendering helper. |
rust/src/domain/suggest.rs |
Protects domain pricing columns and tests them. |
rust/src/domain/quote.rs |
Protects fee and agreement columns. |
rust/src/domain/available.rs |
Protects term pricing columns. |
rust/src/domain/agreements.rs |
Protects agreement URLs. |
rust/src/platform/app/commands/enablements.rs |
Protects application names. |
rust/src/platform/app/commands/init.rs |
Updates view-rendering tests. |
rust/src/platform/app/commands/import.rs |
Updates view-rendering tests. |
rust/src/api/parameter.rs |
Protects parameter names. |
rust/src/api/response.rs |
Protects response statuses. |
rust/src/api/operation.rs |
Protects nested API identifiers. |
rust/src/api/graphql/get.rs |
Protects nested GraphQL names. |
rust/src/api/graphql/type_cmd.rs |
Protects GraphQL field names. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cli-engineto 0.10.0, which adds essential (mandatory) table columns.dns listnow renders through a declared view, so its type, name, and data columns are protected too.Essential columns by view (nested tables inside single-object views are included, since they are width-fitted too):
dns listdns adddns delete(dry-run)dns set(plan)domain suggestdomain agreementsdomain availabledomain quoteplatform app enablementsapi parameter list/api response listapi operation getapi graphql get/typeCommands that only set default fields (no declared view) can't carry the flag and are unchanged.
Test plan
cargo check --workspacecargo clippy --workspace -- -D warningscargo test --workspacecargo fmt --check./rust/scripts/check-module-size.shdns list,domain suggest)🤖 Generated with Claude Code