Repository navigation
chore(platform-app): add the generated App Registry GraphQL client crate [DEVEX-1173] - #326
Open
jpage-godaddy wants to merge 1 commit into
Open
jpage-godaddy wants to merge 1 commit into
jpage-godaddy wants to merge 1 commit into
Conversation
jpage-godaddy
requested review from
axburgess-godaddy,
jpearlman-godaddy,
mguerrero3-godaddy,
qcai-godaddy and
rts1-godaddy
as code owners
October 14, 2026 19:29
6 tasks done
jpage-godaddy
added this pull request to stack #327
October 14, 2026 19:33
jpage-godaddy
force-pushed
the
platform-app-client-crate
branch
from
October 14, 2026 20:04
452ecdc to
57fbbe0
Compare
jpage-godaddy
requested review from
sgopalan-godaddy,
smukherjee-godaddy and
wcole1-godaddy
as code owners
October 14, 2026 20:08
…ate [DEVEX-1173] Adds platform-app-client, a typed client for the App Registry subgraph generated at build time by graphql_client from the pinned schema and one .graphql document per operation, matching the generated-client pattern used for domains/hosting/shopping/email. It is not used by the CLI yet. Unset optional mutation inputs are omitted from the request rather than sent as explicit nulls, since the service treats an omitted field as "leave unchanged" and a null as "clear". Responses to credential-bearing operations (CreateApplication) are never shown to the transport observer, so `--debug transport` cannot log the secrets they carry. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
jpage-godaddy
force-pushed
the
platform-app-client-crate
branch
from
October 14, 2026 20:09
57fbbe0 to
b3f54ba
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Credential exposure paths and the inability to express explicit null updates remain unresolved.
3 open findings
What changed in this PR
Adds a generated App Registry client between the pinned-schema work (#325) and the CLI migration (#282). The CLI does not use it yet.
Changes:
- Generates typed requests and responses for 12 GraphQL operations.
- Adds authenticated transport, error handling, and credential-response safeguards.
- Omits unset optional inputs and adds four client tests.
| File | Description |
|---|---|
| rust/platform-app-client/src/lib.rs | Client transport, errors, and tests. |
| rust/platform-app-client/graphql/UpdateApplication.graphql | Application updates. |
| rust/platform-app-client/graphql/GenerateReleaseUploadUrl.graphql | Artifact upload URL generation. |
| rust/platform-app-client/graphql/EnabledStoreApplications.graphql | Enabled store applications query. |
| rust/platform-app-client/graphql/EnableApplication.graphql | Store application enablement. |
| rust/platform-app-client/graphql/DisableApplication.graphql | Store application disablement. |
| rust/platform-app-client/graphql/CreateRelease.graphql | Release creation. |
| rust/platform-app-client/graphql/CreateApplication.graphql | Application creation with credentials. |
| rust/platform-app-client/graphql/ArchiveApplication.graphql | Application archival. |
| rust/platform-app-client/graphql/ApplicationWithLatestRelease.graphql | Application and latest release query. |
| rust/platform-app-client/graphql/ApplicationsList.graphql | Application listing with status filtering. |
| rust/platform-app-client/graphql/Application.graphql | Application lookup. |
| rust/platform-app-client/graphql/ActivateRelease.graphql | Release activation. |
| rust/platform-app-client/Cargo.toml | New client crate dependencies. |
| rust/platform-app-client/build.rs | Type generation and optional-input serialization. |
| rust/Cargo.toml | Registers the workspace member. |
| rust/Cargo.lock | Locks client and code-generation dependencies. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| /// the client secret, webhook secret and public key). Their response bodies | ||
| /// are never handed to the transport observer, so `--debug transport` cannot | ||
| /// write them into a trace. | ||
| const SECRET_RESPONSE_OPERATIONS: &[&str] = &["CreateApplication"]; |
Comment on lines
+128
to
+131
| body: format!( | ||
| "invalid JSON response: {e} (body: {})", | ||
| String::from_utf8_lossy(&bytes) | ||
| ), |
Comment on lines
+42
to
+45
| if is_option(&field.ty) { | ||
| field.attrs.push(syn::parse_quote!( | ||
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| )); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
platform-app-client, a typed client for the App Registry subgraph generated at build time bygraphql_clientfrom the pinned schema (feat(api): add App Registry to the browsable API catalog [DEVEX-1173] #325) and one.graphqldocument per operation (12 operations). It follows the generated-client pattern already used for domains/hosting/shopping/email, including the shared transport-observer bridge ingenerated-client-support.null: the service treats an omitted field as "leave unchanged" andnullas "clear". Covered by a wire-shape test in the follow-up PR.CreateApplication, which returns the client secret, webhook secret and public key) are never handed to the transport observer, so--debug transportcannot log them. A crate test fails if they leak.Second of three PRs for DEVEX-1173. Stacked on #325; the migration that uses this crate is #282.
Test plan
cargo check --workspacecargo clippy --workspace --all-targets -- -D warningscargo test --workspace(including the crate's 4 tests)cargo fmt --check./rust/scripts/check-module-size.sh🤖 Generated with Claude Code