Skip to content

Track shared library binaries with git LFS - #129

Closed
G4m4 wants to merge 1 commit into
godotengine:mainfrom
G4m4:lfs_attributes
Closed

Track shared library binaries with git LFS#129
G4m4 wants to merge 1 commit into
godotengine:mainfrom
G4m4:lfs_attributes

Conversation

@G4m4

@G4m4 G4m4 commented Aug 17, 2026

Copy link
Copy Markdown

As it is advised to copy this template to use it, I figured it was a good idea to update the git attributes file so built binaries are handled by git LFS in users repos: this is what I needed myself.

This commit only does that as I supposed it was pretty much self-explanatory but if more is needed let me know!

@paddy-exe

Copy link
Copy Markdown
Collaborator

Hey, thanks for opening a PR! Is it mandatory to have git LFS installed? Would this cause any issues for users not having it installed and using the changed .gitattributes file?

@dsnopek

dsnopek commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

I don't think we should put this in the template. These sort of files are definitely ones that some folks would use LFS for, but not everyone uses (or likes) LFS - in fact, there are folks who really dislike it. I don't think we should be making this decision for the user

@Calinou Calinou added the enhancement New feature or request label Aug 17, 2026
@fire

fire commented Aug 17, 2026

Copy link
Copy Markdown
Member

Please do not track LFS on github.

The quota of 50 gigabyte fills up in 1 day.

@G4m4

G4m4 commented Aug 18, 2026

Copy link
Copy Markdown
Author

Please notice that Github size quotas apply whether using LFS or not, just in different ways. This is only relevant to Github business model for which I have absolutely no regard.

But I do agree that we should not force a choice to the users, I am closing this PR.

@G4m4 G4m4 closed this Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants